Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2348183003: Test synthetic pointer action on pointer event tests (Closed)

Created:
4 years, 3 months ago by lanwei
Modified:
3 years, 11 months ago
Reviewers:
Navid Zolghadr
CC:
chromium-reviews, extensions-reviews_chromium.org, blink-reviews-w3ctests_chromium.org, mlamouri+watch-content_chromium.org, tfarina, jam, dtapuska+chromiumwatch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test synthetic pointer action on pointer event tests. BUG=525187

Patch Set 1 #

Total comments: 3

Patch Set 2 : controller #

Patch Set 3 : test #

Patch Set 4 : pointer tests #

Patch Set 5 : pointer event tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -9 lines) Patch
M content/renderer/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A content/renderer/gpu/actions_runner.h View 1 2 3 4 1 chunk +55 lines, -0 lines 0 comments Download
A content/renderer/gpu/actions_runner.cc View 1 2 3 4 1 chunk +208 lines, -0 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 2 3 4 5 chunks +53 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js View 1 2 3 4 4 chunks +79 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (6 generated)
Navid Zolghadr
4 years, 3 months ago (2016-09-21 10:38:49 UTC) #3
I only commented on the files that were added on top of the other review here.

https://codereview.chromium.org/2348183003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointermove_pointertype-manual.html
(right):

https://codereview.chromium.org/2348183003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt/pointerevents/pointerevent_pointermove_pointertype-manual.html:40:
console.log('pointerdown ' + event.pointerId);
I don't think you need these logs anymore. Right?

https://codereview.chromium.org/2348183003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js
(right):

https://codereview.chromium.org/2348183003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:59:
function mouseMoveIntoTargetGPU(targetSelector, offset=0) {
Wouldn't it be easier to just change existing mouseMoveIntoTarget function and
also just get rid of mouseClickInTarget1? or would some tests fail?

https://codereview.chromium.org/2348183003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/imported/wpt_automation/pointerevents/pointerevent_common_input.js:159:
chrome.gpuBenchmarking.touchActionSequence(1, 0, targetRect.left +
boundaryOffset, targetRect.top + boundaryOffset, 1);
Is there a way to somehow expose these action numbers or types through some
strings? something like action number 1 ->
chrome.gpuBenchmarking.pointerAction.Press?

Powered by Google App Engine
This is Rietveld 408576698