Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 234813003: gyp: fix O(n^2) in dependency calculations. (Closed)

Created:
6 years, 8 months ago by Daniel Bratell
Modified:
6 years, 8 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Visibility:
Public.

Description

gyp: fix O(n^2) in dependency calculations. With 1000 targets an O(n^2) in the dependency management starts to be noticed. This patch takes a 0.2s function to 0.02s. The function is not parallelized so this is a true 1% speedup. Also commented on another *potential* performance problem with very specific dependency graphs. BUG=362075 1898

Patch Set 1 #

Total comments: 2

Patch Set 2 : flat_set: Now with comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M pylib/gyp/input.py View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Bratell
Another O(n^2) in the dependency code. Nobody imagined a system with 1100+ targets when the ...
6 years, 8 months ago (2014-04-11 14:08:40 UTC) #1
scottmg
lgtm https://codereview.chromium.org/234813003/diff/1/pylib/gyp/input.py File pylib/gyp/input.py (right): https://codereview.chromium.org/234813003/diff/1/pylib/gyp/input.py#newcode1483 pylib/gyp/input.py:1483: flat_set = set() comment here to the effect ...
6 years, 8 months ago (2014-04-11 18:28:26 UTC) #2
Daniel Bratell
https://codereview.chromium.org/234813003/diff/1/pylib/gyp/input.py File pylib/gyp/input.py (right): https://codereview.chromium.org/234813003/diff/1/pylib/gyp/input.py#newcode1483 pylib/gyp/input.py:1483: flat_set = set() On 2014/04/11 18:28:26, scottmg wrote: > ...
6 years, 8 months ago (2014-04-14 12:18:27 UTC) #3
Nico
6 years, 8 months ago (2014-04-16 15:34:41 UTC) #4
r1898

Powered by Google App Engine
This is Rietveld 408576698