Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issue 2348063002: Comment out TestEventInContext (Closed)

Created:
4 years, 3 months ago by chiniforooshan
Modified:
4 years, 3 months ago
CC:
fmeawad, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Comment out TestEventInContext The test does not compile with https://codereview.chromium.org/2253973003. I will comment it out, land the mentioned patch, fix the compile error (a simple one-liner), and enable the test again. BUG=647986 Committed: https://crrev.com/04c8a368491d5b4ab4901ece7002c148494233fd Cr-Commit-Position: refs/heads/master@{#39505}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/cctest/test-trace-event.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
chiniforooshan
On 2016/09/17 22:06:58, chiniforooshan wrote: > https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=chiniforooshan@chromium.org changed reviewers: > + https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=jochen@chromium.org PTAL, Thanks!
4 years, 3 months ago (2016-09-17 22:09:57 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-19 14:28:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2348063002/20001
4 years, 3 months ago (2016-09-19 14:29:50 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 15:02:57 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 15:03:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04c8a368491d5b4ab4901ece7002c148494233fd
Cr-Commit-Position: refs/heads/master@{#39505}

Powered by Google App Engine
This is Rietveld 408576698