Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/test-trace-event.cc

Issue 2348063002: Comment out TestEventInContext (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-trace-event.cc
diff --git a/test/cctest/test-trace-event.cc b/test/cctest/test-trace-event.cc
index 190cb4078296a3e919ffa8fbd6c9f73b5791aa54..3327e342a3d4d92788f1dea132d16bb118c2227d 100644
--- a/test/cctest/test-trace-event.cc
+++ b/test/cctest/test-trace-event.cc
@@ -257,6 +257,10 @@ TEST(TestEventWithId) {
i::V8::SetPlatformForTesting(old_platform);
}
+/*
+TODO(chiniforooshan, crbug.com/647986): enable this again after landing
+https://codereview.chromium.org/2253973003
+
TEST(TestEventInContext) {
v8::Platform* old_platform = i::V8::GetCurrentPlatform();
MockTracingPlatform platform(old_platform);
@@ -280,3 +284,4 @@ TEST(TestEventInContext) {
i::V8::SetPlatformForTesting(old_platform);
}
+*/
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698