chrome/test/ui/ui_test_suite.cc - Issue 23480061: GTTF: launch test processes using job objects on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/ui/ui_test_suite.cc

Issue 23480061: GTTF: launch test processes using job objects on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/component_patcher_win.cc ('k') | net/test/spawned_test_server/local_test_server_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/ui/ui_test_suite.cc

diff --git a/chrome/test/ui/ui_test_suite.cc b/chrome/test/ui/ui_test_suite.cc

index 690a368ac0927771eaa05b6abf63e7b277d280e4..50cd2d53efbd0e2b1908ab57509e3285c2f52a47 100644

--- a/chrome/test/ui/ui_test_suite.cc

+++ b/chrome/test/ui/ui_test_suite.cc

@@ -54,8 +54,9 @@ void UITestSuite::LoadCrashService() {

return;

}

- if (!base::SetJobObjectAsKillOnJobClose(job_handle_.Get())) {

- LOG(ERROR) << "Could not SetInformationJobObject.";

+ if (!base::SetJobObjectLimitFlags(job_handle_.Get(),

+ JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE)) {

+ LOG(ERROR) << "Could not SetJobObjectLimitFlags.";

return;

}

« no previous file with comments | « chrome/browser/component_updater/component_patcher_win.cc ('k') | net/test/spawned_test_server/local_test_server_win.cc » ('j') | no next file with comments »