Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1363)

Unified Diff: chrome/browser/component_updater/component_patcher_win.cc

Issue 23480061: GTTF: launch test processes using job objects on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/test_launcher.cc ('k') | chrome/test/ui/ui_test_suite.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/component_patcher_win.cc
diff --git a/chrome/browser/component_updater/component_patcher_win.cc b/chrome/browser/component_updater/component_patcher_win.cc
index d583819241b6134d57c3ada9048de8963c265765..20160b0e025629fb0b5efb09d13fa8b331bbd2e6 100644
--- a/chrome/browser/component_updater/component_patcher_win.cc
+++ b/chrome/browser/component_updater/component_patcher_win.cc
@@ -85,7 +85,8 @@ ComponentUnpacker::Error ComponentPatcherWin::Patch(
// child processes around when the parent process exits, either gracefully or
// accidentally.
base::win::ScopedHandle job(CreateJobObject(NULL, NULL));
- if (!job || !base::SetJobObjectAsKillOnJobClose(job)) {
+ if (!job ||
+ !base::SetJobObjectLimitFlags(job, JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE)) {
*error = GetLastError();
return ComponentUnpacker::kDeltaPatchProcessFailure;
}
« no previous file with comments | « base/test/test_launcher.cc ('k') | chrome/test/ui/ui_test_suite.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698