Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 23480056: Create a child window as part of GLX surfaces. (Closed)

Created:
7 years, 3 months ago by ccameron
Modified:
7 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Visibility:
Public.

Description

Create a child window as part of GLX surfaces. Some NVIDIA drivers don't allow deleting GLX windows separately from their parent X windows. Work around this by creating a child X window to the window passed in, creating the GLX window against the child window, and then destroying the child window to destroy the GLX window. Because the child window covers the parent window, it will receive all expose events instead of the parent. Set up an explicit forwarding of these events from the child window to the parent window. Note that this patch does not ever destroy the child window -- that will come in a separate patch. BUG=145600

Patch Set 1 #

Patch Set 2 : Presubmit checks #

Patch Set 3 : Fix comment typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -13 lines) Patch
M ui/gl/gl_surface_glx.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl_surface_glx.cc View 1 2 9 chunks +103 lines, -12 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698