runtime/vm/flow_graph_compiler_arm.cc - Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 23480005: Change Bool::Get to return a handle instead of a pointer to a raw object. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_arm.cc

diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc

index 5fc4e0c313969bdaf60895db1bcc39077ec71f76..0f502ccf62b8440aef388f5de36525b444f06660 100644

--- a/runtime/vm/flow_graph_compiler_arm.cc

+++ b/runtime/vm/flow_graph_compiler_arm.cc

@@ -619,11 +619,11 @@ void FlowGraphCompiler::GenerateInstanceOf(intptr_t token_pos,

__ b(&done);

}

__ Bind(&is_not_instance);

- __ LoadObject(R0, negate_result ? Bool::True() : Bool::False());

+ __ LoadObject(R0, Bool::Get(negate_result));

__ b(&done);

__ Bind(&is_instance);

- __ LoadObject(R0, negate_result ? Bool::False() : Bool::True());

+ __ LoadObject(R0, Bool::Get(!negate_result));

__ Bind(&done);

// Remove instantiator (R2) and its type arguments (R1).

__ Drop(2);

« no previous file with comments | « runtime/vm/flow_graph_builder.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | runtime/vm/object.h » ('J')