[modules] Introduce v8::Module to the API and return it from CompileModule

[modules] Introduce v8::Module to the API and return it from CompileModule

R=neis@chromium.org
BUG=v8:1569
Committed: https://crrev.com/aa6db9d99075f16007ea8fda4509a94ede4e80b6
Cr-Commit-Position: refs/heads/master@{#39481}

[adamk, 2016-09-16 20:12:53]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 20:13:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 20:48:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 20:48:47]

Dry run: This issue passed the CQ dry run.

[neis, 2016-09-16 20:53:33]

https://codereview.chromium.org/2347933002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2347933002/diff/1/src/api.cc#newcode1904
src/api.cc:1904: return Just(true);
Will this ever return Just(false)? Or can we just use bool?

https://codereview.chromium.org/2347933002/diff/1/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2347933002/diff/1/src/d8.cc#newcode463
src/d8.cc:463: ScriptCompiler::CompileOptions compile_options, SourceType
source_type) {
This shouldn't take a SourceType anymore.

https://codereview.chromium.org/2347933002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2347933002/diff/1/src/objects.h#newcode7876
src/objects.h:7876: // on whether it's been
... instantiated?

[adamk, 2016-09-16 20:58:06]

https://codereview.chromium.org/2347933002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2347933002/diff/1/src/api.cc#newcode1904
src/api.cc:1904: return Just(true);
On 2016/09/16 20:53:33, neis wrote:
> Will this ever return Just(false)? Or can we just use bool?

This method will be able to throw exceptions in the future. We don't have a good
type for "Maybe<void>", though, and Maybe types are the way we usually signal
exceptions to the embedder.

I'll defer to Jochen on this though.

https://codereview.chromium.org/2347933002/diff/1/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2347933002/diff/1/src/d8.cc#newcode463
src/d8.cc:463: ScriptCompiler::CompileOptions compile_options, SourceType
source_type) {
On 2016/09/16 20:53:33, neis wrote:
> This shouldn't take a SourceType anymore.

Done.

https://codereview.chromium.org/2347933002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2347933002/diff/1/src/objects.h#newcode7876
src/objects.h:7876: // on whether it's been
On 2016/09/16 20:53:33, neis wrote:
> ... instantiated?

Done.

[adamk, 2016-09-16 20:58:26]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 20:58:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-09-16 20:58:39]

adamk@chromium.org changed reviewers:
+ jochen@chromium.org

[adamk, 2016-09-16 20:58:39]

+jochen for API

[neis, 2016-09-16 21:02:23]

lgtm

[adamk, 2016-09-16 21:02:43]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 21:02:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-09-16 21:16:08]

Actually decided to go with bool for the return value of Instantiate.

Jochen, I'm going to land this now given that this is an "experimental do not
use" API, feel free to chime in asynchronously.

[adamk, 2016-09-16 21:16:12]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-09-16 21:16:13]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2347933002/#ps60001
(title: "Less maybe")

[commit-bot: I haz the power, 2016-09-16 21:16:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 21:47:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-16 21:48:02]

Description was changed from

==========
[modules] Introduce v8::Module to the API and return it from CompileModule

R=neis@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Introduce v8::Module to the API and return it from CompileModule

R=neis@chromium.org
BUG=v8:1569

Committed: https://crrev.com/aa6db9d99075f16007ea8fda4509a94ede4e80b6
Cr-Commit-Position: refs/heads/master@{#39481}
==========

[commit-bot: I haz the power, 2016-09-16 21:48:03]

Patchset 4 (id:??) landed as
https://crrev.com/aa6db9d99075f16007ea8fda4509a94ede4e80b6
Cr-Commit-Position: refs/heads/master@{#39481}