src/factory.h - Issue 2347933002: [modules] Introduce v8::Module to the API and return it from CompileModule

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.h

Issue 2347933002: [modules] Introduce v8::Module to the API and return it from CompileModule (Closed)

Patch Set: Less maybe Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.h

diff --git a/src/factory.h b/src/factory.h

index 097899bdcbe9b3c15fde4bcd423fb14afc6b91a1..0a58341470bfc0fcf332e34ea71ebcff836ec9ef 100644

--- a/src/factory.h

+++ b/src/factory.h

@@ -477,7 +477,7 @@ class Factory final {

Handle<JSGeneratorObject> NewJSGeneratorObject(Handle<JSFunction> function);

- Handle<Module> NewModule(int min_size);

+ Handle<Module> NewModule(Handle<SharedFunctionInfo> code, int min_size);

Handle<JSArrayBuffer> NewJSArrayBuffer(

SharedFlag shared = SharedFlag::kNotShared,

« no previous file with comments | « src/d8.cc ('k') | src/factory.cc » ('j') | no next file with comments »