GN: enable Vulkan on Android when API >= 24.

GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default here than 'false'.  If for some reason you wanted to turn it off, you can still override skia_use_vulkan.

The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not have an ndk_api argument defined in their BUILDCONFIG.gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003

Committed: https://skia.googlesource.com/skia/+/f29180e65afdd3bd5ff3c1a2f8d456f9aea125ed

[mtklein_C, 2016-09-16 12:46:06]

Description was changed from

==========
GN: enable Vulkan on Android when API >= 24.

API >= 24 implies Vulkan support.  So one thing to set instead of two.

BUG=skia:
==========

to

==========
GN: enable Vulkan on Android when API >= 24.

API >= 24 implies Vulkan support.  So one thing to set instead of two.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

[mtklein_C, 2016-09-16 12:47:45]

Description was changed from

==========
GN: enable Vulkan on Android when API >= 24.

API >= 24 implies Vulkan support.  So one thing to set instead of two.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

to

==========
GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default
here than 'false'.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

[mtklein_C, 2016-09-16 12:48:22]

Description was changed from

==========
GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default
here than 'false'.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

to

==========
GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default
here than 'false'.

The defined(ndk_api) guards other users of our GN files (i.e. Fuchsia) who don't
have an ndk_api argument defined in their BUILDCONFIG.gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

[mtklein_C, 2016-09-16 12:48:47]

Description was changed from

==========
GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default
here than 'false'.

The defined(ndk_api) guards other users of our GN files (i.e. Fuchsia) who don't
have an ndk_api argument defined in their BUILDCONFIG.gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

to

==========
GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default
here than 'false'.

The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not
have an ndk_api argument defined in their BUILDCONFIG.gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

[mtklein_C, 2016-09-16 12:49:45]

Description was changed from

==========
GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default
here than 'false'.

The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not
have an ndk_api argument defined in their BUILDCONFIG.gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

to

==========
GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default
here than 'false'.  If for some reason you wanted to turn it off, you can still
override skia_use_vulkan.

The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not
have an ndk_api argument defined in their BUILDCONFIG.gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

[mtklein_C, 2016-09-16 12:52:24]

mtklein@chromium.org changed reviewers:
+ egdaniel@google.com

[egdaniel, 2016-09-16 13:23:09]

I actually don't know this but does 24 actually mean vulkan is supported or does
vulkan support mean at least 24? If it is the former than LGTM,
otherwise...maybe

[mtklein, 2016-09-16 13:24:06]

On 2016/09/16 13:23:09, egdaniel wrote:
> I actually don't know this but does 24 actually mean vulkan is supported or
does
> vulkan support mean at least 24? If it is the former than LGTM,
> otherwise...maybe

24 means Vulkan, as written.

[mtklein, 2016-09-16 13:24:18]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-09-16 13:24:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[egdaniel, 2016-09-16 13:32:46]

On 2016/09/16 13:24:06, mtklein wrote:
> On 2016/09/16 13:23:09, egdaniel wrote:
> > I actually don't know this but does 24 actually mean vulkan is supported or
> does
> > vulkan support mean at least 24? If it is the former than LGTM,
> > otherwise...maybe
> 
> 24 means Vulkan, as written.

I mean will we ever update a device to 24 which doesn't have vulkan support? Or
in android world are those two things equivalent.

[mtklein_C, 2016-09-16 13:44:42]

On 2016/09/16 at 13:32:46, egdaniel wrote:
> On 2016/09/16 13:24:06, mtklein wrote:
> > On 2016/09/16 13:23:09, egdaniel wrote:
> > > I actually don't know this but does 24 actually mean vulkan is supported
or
> > does
> > > vulkan support mean at least 24? If it is the former than LGTM,
> > > otherwise...maybe
> > 
> > 24 means Vulkan, as written.
> 
> I mean will we ever update a device to 24 which doesn't have vulkan support?
Or in android world are those two things equivalent.

API 24 means Android N, and Vulkan's a supported feature of that platform. 
Whether the device supports Vulkan or not is actually moot... we're only
compiling against the OS APIs, not any particular device APIs.  Our builds are
architecture and OS specific, but not device specific.

Some non-24 devices support Vulkan too (S7, Shield), and we're just getting away
with saying "target 24" because we happen to not be using anything else new.

[commit-bot: I haz the power, 2016-09-16 14:01:22]

Description was changed from

==========
GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default
here than 'false'.  If for some reason you wanted to turn it off, you can still
override skia_use_vulkan.

The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not
have an ndk_api argument defined in their BUILDCONFIG.gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003
==========

to

==========
GN: enable Vulkan on Android when API >= 24.

Android API >= 24 implies Vulkan support, so we can have a more useful default
here than 'false'.  If for some reason you wanted to turn it off, you can still
override skia_use_vulkan.

The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not
have an ndk_api argument defined in their BUILDCONFIG.gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003

Committed:
https://skia.googlesource.com/skia/+/f29180e65afdd3bd5ff3c1a2f8d456f9aea125ed
==========

[commit-bot: I haz the power, 2016-09-16 14:01:23]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f29180e65afdd3bd5ff3c1a2f8d456f9aea125ed