infra/bots/recipe_modules/flavor/gn_android_flavor.py - Issue 2347843003: GN: enable Vulkan on Android when API >= 24.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipe_modules/flavor/gn_android_flavor.py

Issue 2347843003: GN: enable Vulkan on Android when API >= 24. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/bots/recipe_modules/flavor/gn_android_flavor.py

diff --git a/infra/bots/recipe_modules/flavor/gn_android_flavor.py b/infra/bots/recipe_modules/flavor/gn_android_flavor.py

index 80952e8c8eb6128a156bc3780c8e508ba99b6fc7..453049a47442618e8cf63ea77db52b19a4e6661a 100644

--- a/infra/bots/recipe_modules/flavor/gn_android_flavor.py

+++ b/infra/bots/recipe_modules/flavor/gn_android_flavor.py

@@ -62,7 +62,6 @@ class GNAndroidFlavorUtils(default_flavor.DefaultFlavorUtils):

if configuration != 'Debug':

args['is_debug'] = 'false'

if 'Vulkan' in extra_config:

- args['skia_use_vulkan'] = 'true'

args['ndk_api'] = 24

gn_args = ' '.join('%s=%s' % (k,v) for (k,v) in sorted(args.iteritems()))