chrome/renderer/extensions/dispatcher.cc - Issue 23478003: Check and canonicalize CSS selectors before registering PageStateMatchers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/dispatcher.cc

Issue 23478003: Check and canonicalize CSS selectors before registering PageStateMatchers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use WebKit::canonicalizeSelector() instead of CSSStyleRule.selectorText Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/test.json ('K') | « chrome/common/extensions/api/test.json ('k') | chrome/renderer/extensions/schema_utils_native_handler.h » ('j') | chrome/renderer/extensions/schema_utils_native_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/dispatcher.cc

diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc

index 0c112fe4f68b17f8f5f98729f375fabfce4a7cc8..b8f1103ced223e9ab3dc1f82518b92e6ee47a5f4 100644

--- a/chrome/renderer/extensions/dispatcher.cc

+++ b/chrome/renderer/extensions/dispatcher.cc

@@ -63,6 +63,7 @@

#include "chrome/renderer/extensions/request_sender.h"

#include "chrome/renderer/extensions/runtime_custom_bindings.h"

#include "chrome/renderer/extensions/safe_builtins.h"

+#include "chrome/renderer/extensions/schema_utils_native_handler.h"

#include "chrome/renderer/extensions/send_request_natives.h"

#include "chrome/renderer/extensions/set_icon_natives.h"

#include "chrome/renderer/extensions/sync_file_system_custom_bindings.h"

@@ -1066,6 +1067,9 @@ void Dispatcher::DidCreateScriptContext(

scoped_ptr<NativeHandler>(new LoggingNativeHandler(context)));

module_system->RegisterNativeHandler("schema_registry",

v8_schema_registry_->AsNativeHandler());

+ module_system->RegisterNativeHandler(

+ "schema_utils",

Jeffrey Yasskin 2013/08/29 03:39:39 Want to pick a better name for this?

not at google - send to devlin 2013/08/29 15:20:25 Sure. This is specifically for supporting declarat

Jeffrey Yasskin 2013/08/29 21:46:43 Decided on css_natives over IM.

+ scoped_ptr<NativeHandler>(new SchemaUtilsNativeHandler(context)));

module_system->RegisterNativeHandler("v8_context",

scoped_ptr<NativeHandler>(new V8ContextNativeHandler(context, this)));

module_system->RegisterNativeHandler("test_features",