chrome/common/extensions/api/test.json - Issue 23478003: Check and canonicalize CSS selectors before registering PageStateMatchers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/test.json

Issue 23478003: Check and canonicalize CSS selectors before registering PageStateMatchers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use WebKit::canonicalizeSelector() instead of CSSStyleRule.selectorText Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc ('K') | « chrome/chrome_renderer.gypi ('k') | chrome/renderer/extensions/dispatcher.cc » ('j') | chrome/renderer/extensions/dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/test.json

diff --git a/chrome/common/extensions/api/test.json b/chrome/common/extensions/api/test.json

index 94742b580e909dc8ec3a4cd64c75e05127c36486..e130b237bdd759b46e8a827ff1422e811b306c99 100644

--- a/chrome/common/extensions/api/test.json

+++ b/chrome/common/extensions/api/test.json

@@ -230,7 +230,9 @@

"optional": true

{"type": "array", "items": {"type": "any"}, "name": "args"},

- {"type": "string", "name": "message", "optional": true}

+ {"type": "any", "name": "message", "optional": true,

not at google - send to devlin 2013/08/29 15:20:25 instead: {"choices": [ {"type": "string"}, {"isIn

Jeffrey Yasskin 2013/08/29 21:46:43 More "isInstanceOf". Thanks! I still had to speci

+ "description":

+ "A string or RegExp that must match the exception's message"}

not at google - send to devlin 2013/08/29 15:20:25 indentation here looks weird; it looks like we don

Jeffrey Yasskin 2013/08/29 21:46:43 'k. I've removed the description again now that th

]

{