Fix the disappearance of "Offline" chip from the LocationBar when navigating to a fragment.

Fix the disappearance of "Offline" chip from the LocationBar when navigating to a fragment.

BUG=647117
Committed: https://crrev.com/c1eac5fc313081e76aaf6286464c448cca581147
Cr-Commit-Position: refs/heads/master@{#419094}

[Dmitry Titov, 2016-09-15 23:06:56]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 23:07:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dmitry Titov, 2016-09-15 23:07:41]

dimich@chromium.org changed reviewers:
+ dewittj@chromium.org

[Dmitry Titov, 2016-09-15 23:07:42]

ptal

[dewittj, 2016-09-15 23:17:40]

lgtm provided we always get Start.. and then Finish.. navigation in order...

https://codereview.chromium.org/2347723002/diff/1/chrome/browser/android/offl...
File chrome/browser/android/offline_pages/offline_page_tab_helper.cc (right):

https://codereview.chromium.org/2347723002/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/offline_page_tab_helper.cc:44:
new_offline_page_ = nullptr;
s/new/provisional?

https://codereview.chromium.org/2347723002/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/offline_page_tab_helper.cc:64:
offline_page_ = std::move(new_offline_page_);
new_offline_page_ could be in indeterminate state?

[dewittj, 2016-09-15 23:17:51]

any tests possible?

[Dmitry Titov, 2016-09-16 00:03:40]

On 2016/09/15 23:17:51, dewittj wrote:
> any tests possible?

Will add in separate patch since this one is for merge...

[commit-bot: I haz the power, 2016-09-16 00:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 00:16:35]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Dmitry Titov, 2016-09-16 01:47:08]

The CQ bit was checked by dimich@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 01:47:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 01:56:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 01:56:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Dmitry Titov, 2016-09-16 02:01:26]

https://codereview.chromium.org/2347723002/diff/1/chrome/browser/android/offl...
File chrome/browser/android/offline_pages/offline_page_tab_helper.cc (right):

https://codereview.chromium.org/2347723002/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/offline_page_tab_helper.cc:44:
new_offline_page_ = nullptr;
On 2016/09/15 23:17:40, dewittj wrote:
> s/new/provisional?

Done.

https://codereview.chromium.org/2347723002/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/offline_page_tab_helper.cc:64:
offline_page_ = std::move(new_offline_page_);
On 2016/09/15 23:17:39, dewittj wrote:
> new_offline_page_ could be in indeterminate state?

Done. Explicitly assigned nullptr. Not sure this is needed though :)

[Dmitry Titov, 2016-09-16 03:03:01]

The CQ bit was checked by dimich@chromium.org

[Dmitry Titov, 2016-09-16 03:03:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2347723002/#ps20001
(title: "updated per CR, fixed failing tests.")

[commit-bot: I haz the power, 2016-09-16 03:03:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 03:33:34]

Description was changed from

==========
Fix the disappearance of "Offline" chip from the LocationBar when navigating to
a fragment.

BUG=647117
==========

to

==========
Fix the disappearance of "Offline" chip from the LocationBar when navigating to
a fragment.

BUG=647117

Committed: https://crrev.com/c1eac5fc313081e76aaf6286464c448cca581147
Cr-Commit-Position: refs/heads/master@{#419094}
==========

[commit-bot: I haz the power, 2016-09-16 03:33:35]

Patchset 2 (id:??) landed as
https://crrev.com/c1eac5fc313081e76aaf6286464c448cca581147
Cr-Commit-Position: refs/heads/master@{#419094}