Fix the disappearance of "Offline" chip from the LocationBar when navigating to a fragment.

chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_request_job.h"
 
 #include "base/callback.h"
 #include "base/feature_list.h"
 #include "base/files/file_path.h"
 #include "base/memory/ptr_util.h"
@@ skipping 509 matching lines @@
 }
 
 TEST_F(OfflinePageRequestJobTest, FailedToCreateRequestJob) {
   SimulateHasNetworkConnectivity(false);
 
   // Must be http/https URL.
   InterceptRequest(GURL("ftp://host/doc"), "GET", "", "",
       content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
 
   InterceptRequest(GURL("file:///path/doc"), "GET", "", "",
       content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
 
   // Must be GET method.
   InterceptRequest(
       kTestUrl, "POST", "", "", content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
 
   InterceptRequest(
       kTestUrl, "HEAD", "", "", content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
 
   // Must be main resource.
   InterceptRequest(
       kTestUrl, "POST", "", "", content::RESOURCE_TYPE_SUB_FRAME);
   base::RunLoop().Run();
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
 
   InterceptRequest(
       kTestUrl, "POST", "", "", content::RESOURCE_TYPE_IMAGE);
   base::RunLoop().Run();
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
 }
 
 TEST_F(OfflinePageRequestJobTest, LoadOfflinePageOnDisconnectedNetwork) {
   SimulateHasNetworkConnectivity(false);
 
   InterceptRequest(kTestUrl, "GET", "", "", content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(kTestFileSize2, bytes_read());
-  ASSERT_TRUE(offline_page_tab_helper()->offline_page());
+  ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest());
   EXPECT_EQ(offline_id2(),
-            offline_page_tab_helper()->offline_page()->offline_id);
+            offline_page_tab_helper()->GetOfflinePageForTest()->offline_id);
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           SHOW_OFFLINE_ON_DISCONNECTED_NETWORK);
 }
 
 TEST_F(OfflinePageRequestJobTest, PageNotFoundOnDisconnectedNetwork) {
   SimulateHasNetworkConnectivity(false);
 
   InterceptRequest(kTestUrl2, "GET", "", "", content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           PAGE_NOT_FOUND_ON_DISCONNECTED_NETWORK);
 }
 
 TEST_F(OfflinePageRequestJobTest, LoadOfflinePageOnProhibitivelySlowNetwork) {
   SimulateHasNetworkConnectivity(true);
 
   ScopedEnableProbihibitivelySlowNetwork scoped(url_request_context());
 
   InterceptRequest(kTestUrl, "GET", "", "", content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(kTestFileSize2, bytes_read());
-  ASSERT_TRUE(offline_page_tab_helper()->offline_page());
+  ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest());
   EXPECT_EQ(offline_id2(),
-            offline_page_tab_helper()->offline_page()->offline_id);
+            offline_page_tab_helper()->GetOfflinePageForTest()->offline_id);
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           SHOW_OFFLINE_ON_PROHIBITIVELY_SLOW_NETWORK);
 }
 
 TEST_F(OfflinePageRequestJobTest, PageNotFoundOnProhibitivelySlowNetwork) {
   SimulateHasNetworkConnectivity(true);
 
   ScopedEnableProbihibitivelySlowNetwork scoped(url_request_context());
 
   InterceptRequest(kTestUrl2, "GET", "", "", content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           PAGE_NOT_FOUND_ON_PROHIBITIVELY_SLOW_NETWORK);
 }
 
 TEST_F(OfflinePageRequestJobTest, LoadOfflinePageOnFlakyNetwork) {
   SimulateHasNetworkConnectivity(true);
 
   // When custom offline header exists and contains "reason=error", it means
   // that net error is hit in last request due to flaky network.
   InterceptRequest(
       kTestUrl,
       "GET",
       kOfflinePageHeader,
       std::string(kOfflinePageHeaderReasonKey) + "=" +
           kOfflinePageHeaderReasonValueDueToNetError,
       content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(kTestFileSize2, bytes_read());
-  ASSERT_TRUE(offline_page_tab_helper()->offline_page());
+  ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest());
   EXPECT_EQ(offline_id2(),
-            offline_page_tab_helper()->offline_page()->offline_id);
+            offline_page_tab_helper()->GetOfflinePageForTest()->offline_id);
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           SHOW_OFFLINE_ON_FLAKY_NETWORK);
 }
 
 TEST_F(OfflinePageRequestJobTest, PageNotFoundOnFlakyNetwork) {
   SimulateHasNetworkConnectivity(true);
 
   // When custom offline header exists and contains "reason=error", it means
   // that net error is hit in last request due to flaky network.
   InterceptRequest(
       kTestUrl2,
       "GET",
       kOfflinePageHeader,
       std::string(kOfflinePageHeaderReasonKey) + "=" +
           kOfflinePageHeaderReasonValueDueToNetError,
       content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           PAGE_NOT_FOUND_ON_FLAKY_NETWORK);
 }
 
 TEST_F(OfflinePageRequestJobTest, ForceLoadOfflinePageOnConnectedNetwork) {
   SimulateHasNetworkConnectivity(true);
 
   // When custom offline header exists and contains value other than
   // "reason=error", it means that offline page is forced to load.
   InterceptRequest(
       kTestUrl,
       "GET",
       kOfflinePageHeader,
       std::string(kOfflinePageHeaderReasonKey) + "=download",
       content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(kTestFileSize2, bytes_read());
-  ASSERT_TRUE(offline_page_tab_helper()->offline_page());
+  ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest());
   EXPECT_EQ(offline_id2(),
-            offline_page_tab_helper()->offline_page()->offline_id);
+            offline_page_tab_helper()->GetOfflinePageForTest()->offline_id);
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           SHOW_OFFLINE_ON_CONNECTED_NETWORK);
 }
 
 TEST_F(OfflinePageRequestJobTest, PageNotFoundOnConnectedNetwork) {
   SimulateHasNetworkConnectivity(true);
 
   // When custom offline header exists and contains value other than
   // "reason=error", it means that offline page is forced to load.
   InterceptRequest(
       kTestUrl2,
       "GET",
       kOfflinePageHeader,
       std::string(kOfflinePageHeaderReasonKey) + "=download",
       content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           PAGE_NOT_FOUND_ON_CONNECTED_NETWORK);
 }
 
 TEST_F(OfflinePageRequestJobTest, DoNotLoadOfflinePageOnConnectedNetwork) {
   SimulateHasNetworkConnectivity(true);
 
   InterceptRequest(kTestUrl, "GET", "", "", content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
 }
 
 TEST_F(OfflinePageRequestJobTest, LoadOfflinePageByOfflineID) {
   SimulateHasNetworkConnectivity(true);
 
   InterceptRequest(
       kTestUrl,
       "GET",
       kOfflinePageHeader,
       std::string(kOfflinePageHeaderReasonKey) + "=download " +
           kOfflinePageHeaderIDKey + "=" + base::Int64ToString(offline_id()),
       content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(kTestFileSize, bytes_read());
-  ASSERT_TRUE(offline_page_tab_helper()->offline_page());
+  ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest());
   EXPECT_EQ(offline_id(),
-            offline_page_tab_helper()->offline_page()->offline_id);
+            offline_page_tab_helper()->GetOfflinePageForTest()->offline_id);
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           SHOW_OFFLINE_ON_CONNECTED_NETWORK);
 }
 
 TEST_F(OfflinePageRequestJobTest,
        LoadOfflinePageByOfflineIDAndFallbackToOnlineURL) {
   SimulateHasNetworkConnectivity(true);
 
   // The offline page found with specific offline ID does not match the passed
   // online URL. Should fall back to find the offline page based on the online
   // URL.
   InterceptRequest(
       kTestUrl2,
       "GET",
       kOfflinePageHeader,
       std::string(kOfflinePageHeaderReasonKey) + "=download " +
           kOfflinePageHeaderIDKey + "=" + base::Int64ToString(offline_id()),
       content::RESOURCE_TYPE_MAIN_FRAME);
   base::RunLoop().Run();
 
   EXPECT_EQ(0, bytes_read());
-  EXPECT_FALSE(offline_page_tab_helper()->offline_page());
+  EXPECT_FALSE(offline_page_tab_helper()->GetOfflinePageForTest());
   ExpectAggregatedRequestResultHistogram(
       OfflinePageRequestJob::AggregatedRequestResult::
           PAGE_NOT_FOUND_ON_CONNECTED_NETWORK);
 }
 
 }  // namespace offline_pages