Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Issue 2347663002: [LayoutNG] Multi-exclusion aware layout opportunities (Closed)

Created:
4 years, 3 months ago by eae
Modified:
4 years, 3 months ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Multi-exclusion aware layout opportunities Update layout opportunities implementation to handle multiple exclusions and to support moving down to the next line if no suitable opportunities can be found on the original line or once all those have been exhausted. Very simple and un-optimized algorithm, trading performance for clarity. BUG=635619 R=cbiesinger@chromium.org,ikilpatrick@chromium.org Committed: https://crrev.com/882e244a67cc80983cd3cc9eb648f2df18bcc4bf Cr-Commit-Position: refs/heads/master@{#420025}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address reviwer comments #

Patch Set 3 : Rebase w/HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -86 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 1 2 3 chunks +103 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 1 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 1 2 4 chunks +134 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 44 (24 generated)
eae
4 years, 3 months ago (2016-09-15 17:41:41 UTC) #1
eae
Please hold off reviewing this for a bit.
4 years, 3 months ago (2016-09-15 18:04:20 UTC) #4
eae
Ready for review
4 years, 3 months ago (2016-09-15 20:17:59 UTC) #8
ikilpatrick
cool, I'll have a look after lunch.
4 years, 3 months ago (2016-09-15 20:25:37 UTC) #11
eae
Can haz review?
4 years, 3 months ago (2016-09-16 13:19:59 UTC) #14
ikilpatrick
On 2016/09/16 13:19:59, eae wrote: > Can haz review? The string tests make me happy ...
4 years, 3 months ago (2016-09-16 16:47:37 UTC) #15
ikilpatrick
https://codereview.chromium.org/2347663002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc (right): https://codereview.chromium.org/2347663002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc#newcode143 third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc:143: EXPECT_EQ("0,0 150x400", OpportunityToString(iterator->Next())); where is the "350,0 250x350" exclusion? ...
4 years, 3 months ago (2016-09-16 16:47:51 UTC) #16
eae
Thanks for the review; comments inline. https://codereview.chromium.org/2347663002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc (right): https://codereview.chromium.org/2347663002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc#newcode143 third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc:143: EXPECT_EQ("0,0 150x400", OpportunityToString(iterator->Next())); ...
4 years, 3 months ago (2016-09-16 19:07:49 UTC) #17
eae
PTAL
4 years, 3 months ago (2016-09-20 08:07:50 UTC) #22
ikilpatrick
lgtm https://codereview.chromium.org/2347663002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc (right): https://codereview.chromium.org/2347663002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc#newcode143 third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc:143: EXPECT_EQ("0,0 150x400", OpportunityToString(iterator->Next())); On 2016/09/16 19:07:49, eae wrote: ...
4 years, 3 months ago (2016-09-20 11:05:00 UTC) #23
eae
On 2016/09/20 11:05:00, ikilpatrick wrote: > lgtm > > https://codereview.chromium.org/2347663002/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc > File third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc > (right): ...
4 years, 3 months ago (2016-09-20 11:06:57 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347663002/40001
4 years, 3 months ago (2016-09-20 11:07:17 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/271406) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-20 11:09:30 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347663002/60001
4 years, 3 months ago (2016-09-20 15:02:14 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/229332)
4 years, 3 months ago (2016-09-20 15:33:48 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347663002/80001
4 years, 3 months ago (2016-09-20 16:14:13 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/131585)
4 years, 3 months ago (2016-09-20 16:48:15 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347663002/80001
4 years, 3 months ago (2016-09-21 09:08:33 UTC) #41
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 3 months ago (2016-09-21 10:49:44 UTC) #42
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 10:51:35 UTC) #44
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/882e244a67cc80983cd3cc9eb648f2df18bcc4bf
Cr-Commit-Position: refs/heads/master@{#420025}

Powered by Google App Engine
This is Rietveld 408576698