Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

Issue 2347663002: [LayoutNG] Multi-exclusion aware layout opportunities (Closed)
Patch Set: Rebase w/HEAD Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h
index 0d0d2f468e6783a7caa59a9099e484ebb0b528c5..ddcc899b154d7a8f994ec185abebaf1c75c4627e 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h
@@ -29,8 +29,13 @@ class CORE_EXPORT NGLayoutOpportunityIterator final
}
private:
- void computeForExclusion(unsigned index);
- LayoutUnit heightForOpportunity(LayoutUnit left,
+ void FilterExclusions();
+ bool NextPosition();
+ bool IsValidPosition();
+ void FilterForPosition(Vector<NGExclusion>&);
+ void ComputeOpportunitiesForPosition();
+ LayoutUnit heightForOpportunity(const Vector<NGExclusion>&,
+ LayoutUnit left,
LayoutUnit top,
LayoutUnit right,
LayoutUnit bottom);
@@ -44,7 +49,9 @@ class CORE_EXPORT NGLayoutOpportunityIterator final
bool for_inline_or_bfc_;
Vector<NGExclusion> filtered_exclusions_;
HeapVector<Member<NGConstraintSpace>> current_opportunities_;
- unsigned current_exclusion_idx_;
+
+ LayoutUnit current_x_;
+ LayoutUnit current_y_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698