Added FrameFuture class

Added FrameFuture class

FrameFuture will be passed to hardware renderer so it could block
until the actual frame is ready.

BUG=636164
Committed: https://crrev.com/ce5a8f01558bc67c810f4c261af4402ef4bf59db
Cr-Commit-Position: refs/heads/master@{#422197}

[ojars, 2016-09-16 04:34:14]

ojars@google.com changed reviewers:
+ boliu@chromium.org, hush@chromium.org

[boliu, 2016-09-16 16:26:12]

remember to make sure unit tests compile

and I think we should talk about how FutureFuture synchronization should work..

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
File android_webview/browser/browser_view_renderer.cc (right):

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:240: //    return
current_compositor_frame_consumer_->HasFrameOnUI();
why is this commented out?

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:246: //  if (!frame.frame) {
why is this commented out?

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:256:
std::unique_ptr<ChildFrame> BrowserViewRenderer::CreateChildFrame(
there is only one caller for this method, just inline it in
OnDrawHardwareProcessFrame

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:325: //  if (!child_frame.get()
|| !child_frame->frame.get())
remove?

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
File android_webview/browser/browser_view_renderer.h (right):

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.h:13: #include
"android_webview/browser/child_frame.h"
shouldn't need this, forward declaration should be enough

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
File android_webview/browser/child_frame.cc (right):

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.cc:11: // ChildFrame::ChildFrame(uint32_t
output_surface_id,
ditto

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.cc:20: //    :
output_surface_id(output_surface_id),
ditto

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
File android_webview/browser/child_frame.h (right):

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.h:18: namespace cc {
you can remove this forward declaration

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.h:26: //  ChildFrame(uint32_t
output_surface_id,
commented out code

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.h:29:
scoped_refptr<content::SynchronousCompositor::FrameFuture> frame_future,
const &

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.h:37: // const uint32_t output_surface_id;
ditto

https://codereview.chromium.org/2347563003/diff/1/content/public/browser/andr...
File content/public/browser/android/synchronous_compositor.cc (right):

https://codereview.chromium.org/2347563003/diff/1/content/public/browser/andr...
content/public/browser/android/synchronous_compositor.cc:21: :
waitable_event_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
should be manual

https://codereview.chromium.org/2347563003/diff/1/content/public/browser/andr...
content/public/browser/android/synchronous_compositor.cc:34:
waitable_event_.Wait();
All the waitable_event calls are super expensive. We shouldn't repeat the just
because all over the place.

Hmm, this is actually an interesting exercise how this class should behave. I
think we should talk about this in person.

https://codereview.chromium.org/2347563003/diff/1/content/public/browser/andr...
File content/public/browser/android/synchronous_compositor.h (right):

https://codereview.chromium.org/2347563003/diff/1/content/public/browser/andr...
content/public/browser/android/synchronous_compositor.h:37: class FrameFuture;
remove, this class does not actually exist

[boliu, 2016-09-16 16:45:28]

I'm currently liking the idea that signal/wait should both be at most once,
which can be enforced with DCHECks, taking inspiration from this class:
https://cs.chromium.org/chromium/src/cc/base/completion_event.h?q=waitable_ev...

Ideally the wait will *pass* the frame out of the future. So maybe we don't want
to merge Frame and FrameFuture..

[ojars, 2016-09-19 22:02:37]

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
File android_webview/browser/browser_view_renderer.cc (right):

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:240: //    return
current_compositor_frame_consumer_->HasFrameOnUI();
On 2016/09/16 16:26:11, boliu wrote:
> why is this commented out?

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:240: //    return
current_compositor_frame_consumer_->HasFrameOnUI();
On 2016/09/16 16:26:11, boliu wrote:
> why is this commented out?

Changed back.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:246: //  if (!frame.frame) {
On 2016/09/16 16:26:11, boliu wrote:
> why is this commented out?

Changed back.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:246: //  if (!frame.frame) {
On 2016/09/16 16:26:11, boliu wrote:
> why is this commented out?

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:256:
std::unique_ptr<ChildFrame> BrowserViewRenderer::CreateChildFrame(
On 2016/09/16 16:26:11, boliu wrote:
> there is only one caller for this method, just inline it in
> OnDrawHardwareProcessFrame

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.cc:325: //  if (!child_frame.get()
|| !child_frame->frame.get())
On 2016/09/16 16:26:11, boliu wrote:
> remove?

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
File android_webview/browser/browser_view_renderer.h (right):

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/bro...
android_webview/browser/browser_view_renderer.h:13: #include
"android_webview/browser/child_frame.h"
On 2016/09/16 16:26:12, boliu wrote:
> shouldn't need this, forward declaration should be enough

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
File android_webview/browser/child_frame.cc (right):

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.cc:11: // ChildFrame::ChildFrame(uint32_t
output_surface_id,
On 2016/09/16 16:26:12, boliu wrote:
> ditto

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.cc:20: //    :
output_surface_id(output_surface_id),
On 2016/09/16 16:26:12, boliu wrote:
> ditto

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
File android_webview/browser/child_frame.h (right):

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.h:18: namespace cc {
On 2016/09/16 16:26:12, boliu wrote:
> you can remove this forward declaration

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.h:26: //  ChildFrame(uint32_t
output_surface_id,
On 2016/09/16 16:26:12, boliu wrote:
> commented out code

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.h:29:
scoped_refptr<content::SynchronousCompositor::FrameFuture> frame_future,
On 2016/09/16 16:26:12, boliu wrote:
> const &

Done.

https://codereview.chromium.org/2347563003/diff/1/android_webview/browser/chi...
android_webview/browser/child_frame.h:37: // const uint32_t output_surface_id;
On 2016/09/16 16:26:12, boliu wrote:
> ditto

Done.

https://codereview.chromium.org/2347563003/diff/1/content/public/browser/andr...
File content/public/browser/android/synchronous_compositor.cc (right):

https://codereview.chromium.org/2347563003/diff/1/content/public/browser/andr...
content/public/browser/android/synchronous_compositor.cc:21: :
waitable_event_(base::WaitableEvent::ResetPolicy::AUTOMATIC,
On 2016/09/16 16:26:12, boliu wrote:
> should be manual

Done.

https://codereview.chromium.org/2347563003/diff/1/content/public/browser/andr...
File content/public/browser/android/synchronous_compositor.h (right):

https://codereview.chromium.org/2347563003/diff/1/content/public/browser/andr...
content/public/browser/android/synchronous_compositor.h:37: class FrameFuture;
On 2016/09/16 16:26:12, boliu wrote:
> remove, this class does not actually exist

Done.

[boliu, 2016-09-20 00:27:56]

stop leaving commented out code..

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
File android_webview/browser/browser_view_renderer.cc (right):

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
android_webview/browser/browser_view_renderer.cc:247:
frame_future->getFrame()->frame)) {
can't call getFrame here because we will want to have getFrame pass ownership
but also can't remove this block either because of the binding init ordering
hmmmm I think the only way is to have RenderThreadManager work with both
FrameFuture and Frame, until we can ship the async path :(

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
File android_webview/browser/browser_view_renderer.h (right):

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
android_webview/browser/browser_view_renderer.h:135:
scoped_refptr<content::SynchronousCompositor::FrameFuture> frame_future)
const &

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
File android_webview/browser/hardware_renderer.cc (right):

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
android_webview/browser/hardware_renderer.cc:66: // Wait for frame, then extract
CompositorFrame and
I think HardwareRenderer do not need to be aware of FrameFuture at all. Let's do
the waiting in RenderThreadManager instead.

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
File content/browser/android/synchronous_compositor_host.cc (right):

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
content/browser/android/synchronous_compositor_host.cc:162: auto frame =
base::MakeUnique<SynchronousCompositor::Frame>();
Don't use auto here

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
File content/browser/android/synchronous_compositor_host.h (right):

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
content/browser/android/synchronous_compositor_host.h:62:
scoped_refptr<SynchronousCompositor::FrameFuture> DemandDrawHwAsync(
leave this void for now, if you are not using the return value yet in this CL

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
content/browser/android/synchronous_compositor_host.h:115:
scoped_refptr<SynchronousCompositor::FrameFuture> frame_future_;
you don't need this

https://codereview.chromium.org/2347563003/diff/20001/content/public/browser/...
File content/public/browser/android/synchronous_compositor.h (right):

https://codereview.chromium.org/2347563003/diff/20001/content/public/browser/...
content/public/browser/android/synchronous_compositor.h:68: void Wait();
there should be no Wait or hasFrame, and getFrame should be called only once and
return unique_ptr<Frame> (no need for the SynchronousCompositor:: qualification
here)

Then add DCHECKs to make sure getFrame is only called once, as discussed

[ojars, 2016-09-22 18:21:39]

Now gmail seems to work on both sync and async paths.

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
File android_webview/browser/browser_view_renderer.h (right):

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
android_webview/browser/browser_view_renderer.h:135:
scoped_refptr<content::SynchronousCompositor::FrameFuture> frame_future)
On 2016/09/20 00:27:56, boliu wrote:
> const &

Done.

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
File android_webview/browser/hardware_renderer.cc (right):

https://codereview.chromium.org/2347563003/diff/20001/android_webview/browser...
android_webview/browser/hardware_renderer.cc:66: // Wait for frame, then extract
CompositorFrame and
On 2016/09/20 00:27:56, boliu wrote:
> I think HardwareRenderer do not need to be aware of FrameFuture at all. Let's
do
> the waiting in RenderThreadManager instead.

Done.

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
File content/browser/android/synchronous_compositor_host.cc (right):

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
content/browser/android/synchronous_compositor_host.cc:162: auto frame =
base::MakeUnique<SynchronousCompositor::Frame>();
On 2016/09/20 00:27:56, boliu wrote:
> Don't use auto here

Done.

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
File content/browser/android/synchronous_compositor_host.h (right):

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
content/browser/android/synchronous_compositor_host.h:62:
scoped_refptr<SynchronousCompositor::FrameFuture> DemandDrawHwAsync(
On 2016/09/20 00:27:56, boliu wrote:
> leave this void for now, if you are not using the return value yet in this CL

Done.

https://codereview.chromium.org/2347563003/diff/20001/content/browser/android...
content/browser/android/synchronous_compositor_host.h:115:
scoped_refptr<SynchronousCompositor::FrameFuture> frame_future_;
On 2016/09/20 00:27:56, boliu wrote:
> you don't need this

Done.

https://codereview.chromium.org/2347563003/diff/20001/content/public/browser/...
File content/public/browser/android/synchronous_compositor.h (right):

https://codereview.chromium.org/2347563003/diff/20001/content/public/browser/...
content/public/browser/android/synchronous_compositor.h:68: void Wait();
On 2016/09/20 00:27:56, boliu wrote:
> there should be no Wait or hasFrame, and getFrame should be called only once
and
> return unique_ptr<Frame> (no need for the SynchronousCompositor::
qualification
> here)
> 
> Then add DCHECKs to make sure getFrame is only called once, as discussed

Done.

[boliu, 2016-09-22 23:05:32]

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
File android_webview/browser/browser_view_renderer.cc (right):

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/browser_view_renderer.cc:243: 
nit: remove new blank line

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/browser_view_renderer.cc:274: std::move(frame_future));
don't need move here I think

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
File android_webview/browser/render_thread_manager.cc (right):

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/render_thread_manager.cc:192: frame_future_ =
std::move(frame_future);
AutoLock

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/render_thread_manager.cc:195:
std::unique_ptr<ChildFrame> RenderThreadManager::PassFrameOnRT() {
you need to repeat all this code for PassUncommittedFrameOnUI, so factor out
into a method to avoid code duplication

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/render_thread_manager.cc:200:
!child_frame_->frame.get()) {
this third part of this check should be a DCHECK instead

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
File android_webview/browser/render_thread_manager.h (right):

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/render_thread_manager.h:51: void SetFrameFutureOnUI(
I think you can just merge this with SetFrameOnUI. Have the synchronous pass in 
null frame_future.

https://codereview.chromium.org/2347563003/diff/40001/content/public/browser/...
File content/public/browser/android/synchronous_compositor.h (right):

https://codereview.chromium.org/2347563003/diff/40001/content/public/browser/...
content/public/browser/android/synchronous_compositor.h:70: base::WaitableEvent
waitable_event_;
ordering style:

friend, then destructor, then blank line, then event, then frame

https://codereview.chromium.org/2347563003/diff/40001/content/public/browser/...
content/public/browser/android/synchronous_compositor.h:83: // TODO(ojars):
update this and the next documentation
no change required anymore :p

https://codereview.chromium.org/2347563003/diff/40001/content/public/browser/...
content/public/browser/android/synchronous_compositor.h:84: virtual
SynchronousCompositor::Frame DemandDrawHw(
don't need the SynchronousCompositor:: part

[boliu, 2016-09-22 23:06:23]

add BUG=636164 to description

[ojars, 2016-09-28 00:02:16]

Description was changed from

==========
Added FrameFuture class

FrameFuture will be passed to hardware renderer so it could block
until the actual frame is ready.
==========

to

==========
Added FrameFuture class
BUG=636164

FrameFuture will be passed to hardware renderer so it could block
until the actual frame is ready.
==========

[ojars, 2016-09-28 00:03:26]

Description was changed from

==========
Added FrameFuture class
BUG=636164

FrameFuture will be passed to hardware renderer so it could block
until the actual frame is ready.
==========

to

==========
Added FrameFuture class

FrameFuture will be passed to hardware renderer so it could block
until the actual frame is ready.

BUG=636164
==========

[ojars, 2016-09-28 00:16:05]

Patchset #4 (id:60001) has been deleted

[ojars, 2016-09-28 00:17:59]

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
File android_webview/browser/browser_view_renderer.cc (right):

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/browser_view_renderer.cc:243: 
On 2016/09/22 23:05:31, boliu wrote:
> nit: remove new blank line

Done.

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/browser_view_renderer.cc:274: std::move(frame_future));
On 2016/09/22 23:05:31, boliu wrote:
> don't need move here I think

Done.

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
File android_webview/browser/render_thread_manager.cc (right):

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/render_thread_manager.cc:192: frame_future_ =
std::move(frame_future);
On 2016/09/22 23:05:32, boliu wrote:
> AutoLock

Done.

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/render_thread_manager.cc:195:
std::unique_ptr<ChildFrame> RenderThreadManager::PassFrameOnRT() {
On 2016/09/22 23:05:32, boliu wrote:
> you need to repeat all this code for PassUncommittedFrameOnUI, so factor out
> into a method to avoid code duplication

Done.

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/render_thread_manager.cc:200:
!child_frame_->frame.get()) {
On 2016/09/22 23:05:31, boliu wrote:
> this third part of this check should be a DCHECK instead

Done.

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
File android_webview/browser/render_thread_manager.h (right):

https://codereview.chromium.org/2347563003/diff/40001/android_webview/browser...
android_webview/browser/render_thread_manager.h:51: void SetFrameFutureOnUI(
On 2016/09/22 23:05:32, boliu wrote:
> I think you can just merge this with SetFrameOnUI. Have the synchronous pass
in 
> null frame_future.

Done.

https://codereview.chromium.org/2347563003/diff/40001/content/public/browser/...
File content/public/browser/android/synchronous_compositor.h (right):

https://codereview.chromium.org/2347563003/diff/40001/content/public/browser/...
content/public/browser/android/synchronous_compositor.h:70: base::WaitableEvent
waitable_event_;
On 2016/09/22 23:05:32, boliu wrote:
> ordering style:
> 
> friend, then destructor, then blank line, then event, then frame

Done.

https://codereview.chromium.org/2347563003/diff/40001/content/public/browser/...
content/public/browser/android/synchronous_compositor.h:83: // TODO(ojars):
update this and the next documentation
On 2016/09/22 23:05:32, boliu wrote:
> no change required anymore :p

Done.

https://codereview.chromium.org/2347563003/diff/40001/content/public/browser/...
content/public/browser/android/synchronous_compositor.h:84: virtual
SynchronousCompositor::Frame DemandDrawHw(
On 2016/09/22 23:05:32, boliu wrote:
> don't need the SynchronousCompositor:: part

Done.

[boliu, 2016-09-28 00:36:01]

https://codereview.chromium.org/2347563003/diff/80001/android_webview/browser...
File android_webview/browser/render_thread_manager.cc (right):

https://codereview.chromium.org/2347563003/diff/80001/android_webview/browser...
android_webview/browser/render_thread_manager.cc:193: void
RenderThreadManager::GetSynchronousCompositorFrame() {
this can be a static method, ie it doesn't need to use any state, pass in future
ref, and return unique_ptr<ChildFrame>

https://codereview.chromium.org/2347563003/diff/80001/android_webview/browser...
File android_webview/browser/render_thread_manager.h (right):

https://codereview.chromium.org/2347563003/diff/80001/android_webview/browser...
android_webview/browser/render_thread_manager.h:102: void
GetSynchronousCompositorFrame();
move this above "// RT thread method." as this is actually called from both
threads

[ojars, 2016-09-28 22:44:19]

https://codereview.chromium.org/2347563003/diff/80001/android_webview/browser...
File android_webview/browser/render_thread_manager.cc (right):

https://codereview.chromium.org/2347563003/diff/80001/android_webview/browser...
android_webview/browser/render_thread_manager.cc:193: void
RenderThreadManager::GetSynchronousCompositorFrame() {
On 2016/09/28 00:36:01, boliu wrote:
> this can be a static method, ie it doesn't need to use any state, pass in
future
> ref, and return unique_ptr<ChildFrame>

Done.

https://codereview.chromium.org/2347563003/diff/80001/android_webview/browser...
File android_webview/browser/render_thread_manager.h (right):

https://codereview.chromium.org/2347563003/diff/80001/android_webview/browser...
android_webview/browser/render_thread_manager.h:102: void
GetSynchronousCompositorFrame();
On 2016/09/28 00:36:01, boliu wrote:
> move this above "// RT thread method." as this is actually called from both
> threads

Done.

[boliu, 2016-09-28 22:49:30]

lgtm % last comment

https://codereview.chromium.org/2347563003/diff/100001/android_webview/browse...
File android_webview/browser/render_thread_manager.h (right):

https://codereview.chromium.org/2347563003/diff/100001/android_webview/browse...
android_webview/browser/render_thread_manager.h:105: void
GetSynchronousCompositorFrame();
remove

[ojars, 2016-09-30 19:12:10]

The CQ bit was checked by ojars@google.com

[ojars, 2016-09-30 19:12:11]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2347563003/#ps120001
(title: "Added frame future class")

[commit-bot: I haz the power, 2016-09-30 19:13:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:05:01]

Description was changed from

==========
Added FrameFuture class

FrameFuture will be passed to hardware renderer so it could block
until the actual frame is ready.

BUG=636164
==========

to

==========
Added FrameFuture class

FrameFuture will be passed to hardware renderer so it could block
until the actual frame is ready.

BUG=636164
==========

[commit-bot: I haz the power, 2016-09-30 20:05:02]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-09-30 20:06:56]

Description was changed from

==========
Added FrameFuture class

FrameFuture will be passed to hardware renderer so it could block
until the actual frame is ready.

BUG=636164
==========

to

==========
Added FrameFuture class

FrameFuture will be passed to hardware renderer so it could block
until the actual frame is ready.

BUG=636164

Committed: https://crrev.com/ce5a8f01558bc67c810f4c261af4402ef4bf59db
Cr-Commit-Position: refs/heads/master@{#422197}
==========

[commit-bot: I haz the power, 2016-09-30 20:06:57]

Patchset 6 (id:??) landed as
https://crrev.com/ce5a8f01558bc67c810f4c261af4402ef4bf59db
Cr-Commit-Position: refs/heads/master@{#422197}