Added FrameFuture class

content/public/browser/android/synchronous_compositor.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_H_
 #define CONTENT_PUBLIC_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_H_
 
 #include <stddef.h>
 
 #include <memory>
 
 #include "base/memory/ref_counted.h"
+#include "base/synchronization/waitable_event.h"
 #include "base/time/time.h"
 #include "cc/resources/returned_resource.h"
 #include "content/common/content_export.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size.h"
 
 class SkCanvas;
 
 namespace cc {
 class CompositorFrame;
@@ skipping 29 matching lines @@
     Frame(Frame&& rhs);
     Frame& operator=(Frame&& rhs);
 
     uint32_t compositor_frame_sink_id;
     std::unique_ptr<cc::CompositorFrame> frame;
 
    private:
     DISALLOW_COPY_AND_ASSIGN(Frame);
   };
 
+  class FrameFuture : public base::RefCountedThreadSafe<FrameFuture> {
+   public:
+    FrameFuture();
+    void setFrame(std::unique_ptr<Frame> frame);
+    std::unique_ptr<Frame> getFrame();
+
+   private:
+    base::WaitableEvent waitable_event_;

[boliu, 2016/09/22 23:05:32]

ordering style:

friend, then destructor, then blank line, then event, then frame

[ojars, 2016/09/28 00:17:59]

Done.

+    std::unique_ptr<Frame> frame_;
+    friend class base::RefCountedThreadSafe<FrameFuture>;
+    ~FrameFuture();
+#if DCHECK_IS_ON()
+    bool waited_ = false;
+#endif
+  };
+
   // "On demand" hardware draw. Parameters are used by compositor for this draw.
   // |viewport_size| is the current size to improve results during resize.
   // |viewport_rect_for_tile_priority| and |transform_for_tile_priority| are
   // used to customize the tiling decisions of compositor.
-  virtual Frame DemandDrawHw(
+  // TODO(ojars): update this and the next documentation

[boliu, 2016/09/22 23:05:32]

no change required anymore :p

[ojars, 2016/09/28 00:17:59]

Done.

+  virtual SynchronousCompositor::Frame DemandDrawHw(

[boliu, 2016/09/22 23:05:32]

don't need the SynchronousCompositor:: part

[ojars, 2016/09/28 00:17:59]

Done.

       const gfx::Size& viewport_size,
       const gfx::Rect& viewport_rect_for_tile_priority,
       const gfx::Transform& transform_for_tile_priority) = 0;
 
   // Same as DemandDrawHw, but uses asynchronous IPC messages. Calls
   // SynchronousCompositorClient::OnDrawHardwareProcessFrame to return the
   // frame.
   virtual void DemandDrawHwAsync(
       const gfx::Size& viewport_size,
       const gfx::Rect& viewport_rect_for_tile_priority,
@@ skipping 25 matching lines @@
   // and if any input animation is active, it should tick now.
   virtual void OnComputeScroll(base::TimeTicks animation_time) = 0;
 
  protected:
   virtual ~SynchronousCompositor() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_H_