Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2347473007: Revert of Support Float32 output from SkColorSpaceXform (Closed)

Created:
4 years, 3 months ago by msarett
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Support Float32 output from SkColorSpaceXform (patchset #7 id:140001 of https://codereview.chromium.org/2339233003/ ) Reason for revert: Hitting an assert Original issue's description: > Support Float32 output from SkColorSpaceXform > > * Adds Float32 support to SkColorSpaceXform > * Changes API to allows clients to ask for F32, updates clients to > new API > * Adds Sk4f_load4 and Sk4f_store4 to SkNx > * Make use of new xform in SkGr.cpp > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339233003 > CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > Committed: https://skia.googlesource.com/skia/+/43d6651111374b5d1e4ddd9030dcf079b448ec47 TBR=brianosman@google.com,mtklein@google.com,scroggo@google.com,mtklein@chromium.org,bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c71a9b7f53938b4f33f36f48e867b8b72cc1cc61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -340 lines) Patch
M bench/ColorCodecBench.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
D gm/colorspacexform.cpp View 1 chunk +0 lines, -88 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrDrawContext.h View 3 chunks +12 lines, -13 lines 0 comments Download
M src/codec/SkCodecPriv.h View 3 chunks +2 lines, -16 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/codec/SkPngCodec.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/codec/SkPngCodec.cpp View 6 chunks +13 lines, -29 lines 0 comments Download
M src/codec/SkWebpCodec.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkColorSpaceXform.h View 2 chunks +10 lines, -17 lines 0 comments Download
M src/core/SkColorSpaceXform.cpp View 12 chunks +14 lines, -48 lines 0 comments Download
M src/core/SkNx.h View 1 chunk +0 lines, -22 lines 0 comments Download
M src/core/SkPM4fPriv.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/SkGr.cpp View 2 chunks +9 lines, -12 lines 0 comments Download
M src/opts/SkNx_neon.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 chunk +0 lines, -25 lines 0 comments Download
M tests/ColorSpaceXformTest.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M tests/SkNxTest.cpp View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of Support Float32 output from SkColorSpaceXform
4 years, 3 months ago (2016-09-16 18:01:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347473007/1
4 years, 3 months ago (2016-09-16 18:01:08 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 18:01:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c71a9b7f53938b4f33f36f48e867b8b72cc1cc61

Powered by Google App Engine
This is Rietveld 408576698