Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper

Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper (patchset #4 id:200001 of https://codereview.chromium.org/2310683003/ )

Reason for revert:
Speculative revert from WebRTC-in-Chrome sheriff since it seems like
this CL breaks content_browser tests on Windows 7.

See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/29582/steps/content_browsertests/logs/stdio
for more details.

Original issue's description:
> Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
>
> BUG=509735
>
> Committed: https://crrev.com/8870e560931560b4dae5a1d2c87c5629b1e3c44e
> Cr-Commit-Position: refs/heads/master@{#419008}

TBR=mcasas@chromium.org,sky@chromium.org,jam@chromium.org,tommi@chromium.org,lunalu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509735
Committed: https://crrev.com/186bd185a48f81da08b0120bf98ef62531e8036f
Cr-Commit-Position: refs/heads/master@{#419134}

[henrika (OOO until Aug 14), 2016-09-16 08:46:05]

The CQ bit was checked by henrika@chromium.org

[henrika (OOO until Aug 14), 2016-09-16 08:46:05]

Created Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test
helper

[commit-bot: I haz the power, 2016-09-16 08:46:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 08:47:34]

Description was changed from

==========
Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
(patchset #4 id:200001 of https://codereview.chromium.org/2310683003/ )

Reason for revert:
Speculative revert from WebRTC-in-Chrome sheriff since it seems like
this CL breaks content_browser tests on Windows 7.

See
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/29...

for more details.

Original issue's description:
> Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
> 
> BUG=509735
> 
> Committed: https://crrev.com/8870e560931560b4dae5a1d2c87c5629b1e3c44e
> Cr-Commit-Position: refs/heads/master@{#419008}

TBR=mcasas@chromium.org,sky@chromium.org,jam@chromium.org,tommi@chromium.org,...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509735
==========

to

==========
Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
(patchset #4 id:200001 of https://codereview.chromium.org/2310683003/ )

Reason for revert:
Speculative revert from WebRTC-in-Chrome sheriff since it seems like
this CL breaks content_browser tests on Windows 7.

See
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/29...

for more details.

Original issue's description:
> Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
> 
> BUG=509735
> 
> Committed: https://crrev.com/8870e560931560b4dae5a1d2c87c5629b1e3c44e
> Cr-Commit-Position: refs/heads/master@{#419008}

TBR=mcasas@chromium.org,sky@chromium.org,jam@chromium.org,tommi@chromium.org,...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509735
==========

[commit-bot: I haz the power, 2016-09-16 08:47:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-16 08:51:01]

Description was changed from

==========
Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
(patchset #4 id:200001 of https://codereview.chromium.org/2310683003/ )

Reason for revert:
Speculative revert from WebRTC-in-Chrome sheriff since it seems like
this CL breaks content_browser tests on Windows 7.

See
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/29...

for more details.

Original issue's description:
> Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
> 
> BUG=509735
> 
> Committed: https://crrev.com/8870e560931560b4dae5a1d2c87c5629b1e3c44e
> Cr-Commit-Position: refs/heads/master@{#419008}

TBR=mcasas@chromium.org,sky@chromium.org,jam@chromium.org,tommi@chromium.org,...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509735
==========

to

==========
Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
(patchset #4 id:200001 of https://codereview.chromium.org/2310683003/ )

Reason for revert:
Speculative revert from WebRTC-in-Chrome sheriff since it seems like
this CL breaks content_browser tests on Windows 7.

See
https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/29...
for more details.

Original issue's description:
> Removed duplicated JS hasVideoInputDeviceOnSystem() test helper
>
> BUG=509735
>
> Committed: https://crrev.com/8870e560931560b4dae5a1d2c87c5629b1e3c44e
> Cr-Commit-Position: refs/heads/master@{#419008}

TBR=mcasas@chromium.org,sky@chromium.org,jam@chromium.org,tommi@chromium.org,...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509735

Committed: https://crrev.com/186bd185a48f81da08b0120bf98ef62531e8036f
Cr-Commit-Position: refs/heads/master@{#419134}
==========

[commit-bot: I haz the power, 2016-09-16 08:51:02]

Patchset 1 (id:??) landed as
https://crrev.com/186bd185a48f81da08b0120bf98ef62531e8036f
Cr-Commit-Position: refs/heads/master@{#419134}

[henrika (OOO until Aug 14), 2016-09-16 10:48:42]

Things are starting to clear up after this revert. Seems like the revert was
correct.

[lunalu1, 2016-09-16 14:23:56]

It seems like what was causing the failure was that in the windows test, it
failed to find the reference to "returnToTest". I will try to see if I replace
returnToTest(message) by window.domAutomationController.send(message), the
problem can be fixed, so that no need to revert my previous CL
https://cs.chromium.org/chromium/src/chrome/test/data/webrtc/test_functions.j...

[henrika (OOO until Aug 14), 2016-09-19 07:32:45]

The change had to be reverted since it caused most of our bots to turn red.
Please ensure that all WebRTC tests are working before trying to land again.

On Fri, Sep 16, 2016 at 4:23 PM, <lunalu@chromium.org> wrote:

> It seems like what was causing the failure was that in the windows test, it
> failed to find the reference to "returnToTest". I will try to see if I
> replace
> returnToTest(message) by window.domAutomationController.send(message), the
> problem can be fixed, so that no need to revert my previous CL
> https://cs.chromium.org/chromium/src/chrome/test/data/
> webrtc/test_functions.js?q=returntotest&l=30&dr=C
>
> https://codereview.chromium.org/2347473004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.