chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc - Issue 2347473004: Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc

Issue 2347473004: Revert of Removed duplicated JS hasVideoInputDeviceOnSystem() test helper (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc

diff --git a/chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc b/chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc

index 49665dd84fd713bf8293da30e28507aada04e955..ecc86b0a00b0ed57aabaa828db949305a2f0255a 100644

--- a/chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc

+++ b/chrome/browser/media/webrtc/webrtc_webcam_browsertest.cc

@@ -78,8 +78,8 @@

content::WebContents* tab =

browser()->tab_strip_model()->GetActiveWebContents();

- if (!content::IsWebcamAvailableOnSystem(tab)) {

- DVLOG(0) << "No webcam found on bot: skipping...";

+ if (!HasWebcamAvailableOnSystem(tab)) {

+ LOG(INFO) << "No webcam found on bot: skipping...";

return;

}