Compile the skia library for windows using gn.

Compile the skia library for windows using gn.

TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347443002

Committed: https://skia.googlesource.com/skia/+/b6318bf44dd89dc8465dcf48ba820701eae24acb

[herb_g, 2016-09-14 21:07:11]

Description was changed from

==========
Compile the skia library for windows using gn.

BUG=skia:
==========

to

==========
Compile the skia library for windows using gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347443002
==========

[herb_g, 2016-09-14 21:11:22]

Description was changed from

==========
Compile the skia library for windows using gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347443002
==========

to

==========
Compile the skia library for windows using gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347443002
==========

[herb_g, 2016-09-14 21:11:22]

herb@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-09-14 21:25:15]

https://codereview.chromium.org/2347443002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2347443002/diff/1/BUILD.gn#newcode407
BUILD.gn:407: if (!is_win) {
Probably redundant.

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn
File gn/BUILD.gn (right):

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn#newcode28
gn/BUILD.gn:28: "/Gy",      # Enable function-level linking.
If there is any doubt, let's leave it out.

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn#newcode78
gn/BUILD.gn:78: if (is_android) {
This needs some rebasing.

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn#newcode133
gn/BUILD.gn:133: libs = [ "pthread" ]
This is the source of our global pthread power.

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn#newcode197
gn/BUILD.gn:197: # "$object_subdir/{{source_name_part}}.obj",
Probably can clean up these working drafts.

https://codereview.chromium.org/2347443002/diff/1/third_party/sfntly/BUILD.gn
File third_party/sfntly/BUILD.gn (right):

https://codereview.chromium.org/2347443002/diff/1/third_party/sfntly/BUILD.gn...
third_party/sfntly/BUILD.gn:75: defines += [ "WIN32", "NOMINMAX" ]
Probably do not need NOMINMAX again.

Better check WIN32 matters too?

https://codereview.chromium.org/2347443002/diff/1/third_party/sfntly/BUILD.gn...
third_party/sfntly/BUILD.gn:78: #  "/wd4244",
Can you make the template in third_party/third_party.gni suppress all warnings?

https://codereview.chromium.org/2347443002/diff/1/third_party/sfntly/BUILD.gn...
third_party/sfntly/BUILD.gn:80: cflags_cc = [ "/EHsc", ]
Let's confirm SFNTLY_NO_EXCEPTION doesn't work enough?

[herb_g, 2016-09-16 19:54:15]

https://codereview.chromium.org/2347443002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2347443002/diff/1/BUILD.gn#newcode407
BUILD.gn:407: if (!is_win) {
On 2016/09/14 21:25:14, mtklein wrote:
> Probably redundant.

Done.

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn
File gn/BUILD.gn (right):

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn#newcode28
gn/BUILD.gn:28: "/Gy",      # Enable function-level linking.
On 2016/09/14 21:25:14, mtklein wrote:
> If there is any doubt, let's leave it out.

Done.

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn#newcode78
gn/BUILD.gn:78: if (is_android) {
On 2016/09/14 21:25:14, mtklein wrote:
> This needs some rebasing.

Done.

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn#newcode133
gn/BUILD.gn:133: libs = [ "pthread" ]
On 2016/09/14 21:25:14, mtklein wrote:
> This is the source of our global pthread power. 

Done.

https://codereview.chromium.org/2347443002/diff/1/gn/BUILD.gn#newcode197
gn/BUILD.gn:197: # "$object_subdir/{{source_name_part}}.obj",
On 2016/09/14 21:25:14, mtklein wrote:
> Probably can clean up these working drafts.

Done.

https://codereview.chromium.org/2347443002/diff/1/third_party/sfntly/BUILD.gn
File third_party/sfntly/BUILD.gn (right):

https://codereview.chromium.org/2347443002/diff/1/third_party/sfntly/BUILD.gn...
third_party/sfntly/BUILD.gn:75: defines += [ "WIN32", "NOMINMAX" ]
On 2016/09/14 21:25:14, mtklein wrote:
> Probably do not need NOMINMAX again.
> 
> Better check WIN32 matters too?

Done.

https://codereview.chromium.org/2347443002/diff/1/third_party/sfntly/BUILD.gn...
third_party/sfntly/BUILD.gn:78: #  "/wd4244",
On 2016/09/14 21:25:14, mtklein wrote:
> Can you make the template in third_party/third_party.gni suppress all
warnings?

Done.

https://codereview.chromium.org/2347443002/diff/1/third_party/sfntly/BUILD.gn...
third_party/sfntly/BUILD.gn:80: cflags_cc = [ "/EHsc", ]
On 2016/09/14 21:25:14, mtklein wrote:
> Let's confirm SFNTLY_NO_EXCEPTION doesn't work enough?

Done.

[herb_g, 2016-09-16 19:56:23]

Description was changed from

==========
Compile the skia library for windows using gn.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347443002
==========

to

==========
Compile the skia library for windows using gn.

TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347443002
==========

[herb_g, 2016-09-16 19:56:30]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2016-09-16 19:56:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[herb_g, 2016-09-16 20:00:11]

The CQ bit was unchecked by herb@google.com

[herb_g, 2016-09-16 20:08:58]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2016-09-16 20:09:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-16 20:17:44]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-09-16 20:17:45]

lgtm  *\o/*

[commit-bot: I haz the power, 2016-09-16 20:29:59]

Description was changed from

==========
Compile the skia library for windows using gn.

TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347443002
==========

to

==========
Compile the skia library for windows using gn.

TBR=mtklein@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347443002

Committed:
https://skia.googlesource.com/skia/+/b6318bf44dd89dc8465dcf48ba820701eae24acb
==========

[commit-bot: I haz the power, 2016-09-16 20:30:00]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/b6318bf44dd89dc8465dcf48ba820701eae24acb

[hal.canary, 2016-09-16 21:04:36]

halcanary@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2016-09-16 21:04:37]

https://codereview.chromium.org/2347443002/diff/80001/gn/BUILD.gn
File gn/BUILD.gn (right):

https://codereview.chromium.org/2347443002/diff/80001/gn/BUILD.gn#newcode37
gn/BUILD.gn:37: "WIN32_LEAN_AND_MEAN",
this may not be necessary, since we have SkLeanWindows.h

[mtklein, 2016-09-17 11:54:39]

> https://codereview.chromium.org/2347443002/diff/80001/gn/BUILD.gn#newcode37
> gn/BUILD.gn:37: "WIN32_LEAN_AND_MEAN",
> this may not be necessary, since we have SkLeanWindows.h

Other way around!