third_party/third_party.gni - Issue 2347443002: Compile the skia library for windows using gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/third_party.gni

Issue 2347443002: Compile the skia library for windows using gn. (Closed)

Patch Set: Merge branch 'master' of https://skia.googlesource.com/skia into bring-up-to-date Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/third_party.gni

diff --git a/third_party/third_party.gni b/third_party/third_party.gni

index 34751c028693db62d6d3ad9e412c59af515d3d94..37b1e036878ca773551242763d6ccbd2ccd2321c 100644

--- a/third_party/third_party.gni

+++ b/third_party/third_party.gni

@@ -12,7 +12,11 @@ template("third_party") {

public_configs = [ ":" + target_name + "_public" ]

# Warnings are just noise if we're not maintaining the code.

- cflags = [ "-w" ]

+ if (is_win) {

+ cflags = [ "/w" ]

+ } else {

+ cflags = [ "-w" ]

+ }

}

« gn/BUILD.gn ('K') | « third_party/sfntly/BUILD.gn ('k') | no next file » | no next file with comments »