Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2347423004: Prune CreateVisiblePositionDeprecate from HitTestResult (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune CreateVisiblePositionDeprecate from HitTestResult This patch makes HitTestResult::isMisspelled() call createVisiblePosition() instead of createVisiblePositionDeprecated(), since isMisspelled() is already called with clean layout. BUG=647219 Committed: https://crrev.com/93494a607b9c3effeaf2a8b00a23e16804f80806 Cr-Commit-Position: refs/heads/master@{#419706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/HitTestResult.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-20 07:37:53 UTC) #5
tkent
lgtm > instead of createVisiblePositionDeprecated(), since misMisspelled() is already misMisspelled() -> isMisspelled().
4 years, 3 months ago (2016-09-20 08:10:13 UTC) #6
Xiaocheng
On 2016/09/20 at 08:10:13, tkent wrote: > lgtm > > > instead of createVisiblePositionDeprecated(), since ...
4 years, 3 months ago (2016-09-20 08:13:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347423004/1
4 years, 3 months ago (2016-09-20 09:32:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 09:37:39 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 09:39:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93494a607b9c3effeaf2a8b00a23e16804f80806
Cr-Commit-Position: refs/heads/master@{#419706}

Powered by Google App Engine
This is Rietveld 408576698