Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 23474012: Merged r16224 into 3.19 branch. (Closed)

Created:
7 years, 3 months ago by Jakob Kummerow
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Merged r16224 into 3.19 branch. Fix invalid out-of-bounds store in MacroAssembler::Allocate. BUG=chromium:263515 R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -19 lines) Patch
M src/arm/macro-assembler-arm.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +25 lines, -14 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
7 years, 3 months ago (2013-08-29 12:05:00 UTC) #1
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-08-29 12:06:49 UTC) #2
Jakob Kummerow
Paul, this is a backmerge of https://codereview.chromium.org/23242006. It seems the MIPS changes (https://codereview.chromium.org/23242006/diff/6001/src/mips/macro-assembler-mips.cc) don't apply ...
7 years, 3 months ago (2013-08-29 12:08:55 UTC) #3
Jakob Kummerow
Committed patchset #1 manually as r16423 (presubmit successful).
7 years, 3 months ago (2013-08-29 12:10:11 UTC) #4
Paul Lind
7 years, 3 months ago (2013-08-29 14:43:40 UTC) #5
Message was sent while issue was closed.
On 2013/08/29 12:08:55, Jakob wrote:
> Paul, this is a backmerge of https://codereview.chromium.org/23242006. It
seems
> the MIPS changes
>
(https://codereview.chromium.org/23242006/diff/6001/src/mips/macro-assembler-m...)
> don't apply at all, as both the MIPS MacroAssembler::Allocate(...) methods
> apparently don't support DOUBLE_ALIGNMENT yet. Is that correct?

Correct. Unfortunately we missed porting the original DOUBLE_ALIGNMENT change in
r13284, and only got that fixed in the 3.20 timeframe with r16112. For MIPS at
least, r13284 was a performance issue only; we did not back-merge it to older
branches. And therefore we do not need this fix for 3.19.

Powered by Google App Engine
This is Rietveld 408576698