Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 23242006: Fix invalid out-of-bounds store in MacroAssembler::Allocate. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger
Modified:
7 years, 4 months ago
CC:
v8-dev, palfia
Visibility:
Public.

Description

Fix invalid out-of-bounds store in MacroAssembler::Allocate. This fixes an out-of-bounds store in inlined allocations when double alignment and pretenuring into old-data-space have been requested. R=hpayer@chromium.org, jkummerow@chromium.org, plind44@gmail.com BUG=chromium:263515 Committed: http://code.google.com/p/v8/source/detail?r=16224

Patch Set 1 #

Patch Set 2 : Fix typo for MIPS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -20 lines) Patch
M src/arm/macro-assembler-arm.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +25 lines, -14 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Starzinger
7 years, 4 months ago (2013-08-19 17:21:24 UTC) #1
Jakob Kummerow
LGTM. I'd appreciate it if MIPS people could double-check the MIPS changes.
7 years, 4 months ago (2013-08-19 17:25:09 UTC) #2
Hannes Payer (out of office)
lgtm
7 years, 4 months ago (2013-08-19 17:25:49 UTC) #3
Paul Lind
MIPS change LGTM, thanks for doing it! Just FYI, 'hs' is an alias for 'Ugreater_equal', ...
7 years, 4 months ago (2013-08-19 17:39:06 UTC) #4
Jakob Kummerow
patch set 2 LGTM
7 years, 4 months ago (2013-08-19 17:41:49 UTC) #5
Michael Starzinger
Committed patchset #2 manually as r16224.
7 years, 4 months ago (2013-08-19 17:46:52 UTC) #6
Paul Lind
7 years, 4 months ago (2013-08-19 17:53:16 UTC) #7
Message was sent while issue was closed.
Thanks Michael, sorry I missed that typo on first review, it's good now.

Powered by Google App Engine
This is Rietveld 408576698