Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2347373002: Remove velocities parameters from onFlingStartGesture() (Closed)

Created:
4 years, 3 months ago by Tima Vaisburd
Modified:
4 years, 3 months ago
Reviewers:
Ted C, boliu
CC:
chromium-reviews, jam, dominickn+watch_chromium.org, darin-cc_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove velocities parameters from onFlingStartGesture() This is the part of preparation to DIP scale change processing. These parameters are converted from DIP to pixels but never used. BUG=620929 Committed: https://crrev.com/1f49e889d08b4b9245579fbdc744f2590770f61b Cr-Commit-Position: refs/heads/master@{#419571}

Patch Set 1 #

Messages

Total messages: 13 (7 generated)
Tima Vaisburd
PTAL.
4 years, 3 months ago (2016-09-17 02:52:09 UTC) #4
boliu
lgtm, nice
4 years, 3 months ago (2016-09-19 16:39:34 UTC) #7
Ted C
lgtm
4 years, 3 months ago (2016-09-19 20:15:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347373002/1
4 years, 3 months ago (2016-09-19 20:21:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 21:45:21 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:48:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f49e889d08b4b9245579fbdc744f2590770f61b
Cr-Commit-Position: refs/heads/master@{#419571}

Powered by Google App Engine
This is Rietveld 408576698