android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java - Issue 2347373002: Remove velocities parameters from onFlingStartGesture()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java

Issue 2347373002: Remove velocities parameters from onFlingStartGesture() (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java

diff --git a/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java b/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java

index 128b3a0187e73b8cd69e67c91475924f28e860e8..fdfb46c90beb2c88ed9f15b3c5f402cff527cbc5 100644

--- a/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java

+++ b/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java

@@ -142,7 +142,7 @@ public class PopupTouchHandleDrawable extends View {

setIsScrolling(false);

}

@Override

- public void onFlingStartGesture(int vx, int vy, int scrollOffsetY, int scrollExtentY) {

+ public void onFlingStartGesture(int scrollOffsetY, int scrollExtentY) {

// Fling accounting is unreliable in WebView, as the embedder

// can override onScroll() and suppress fling ticking. At best

// we have to rely on the scroll offset changing to temporarily

« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java » ('j') | no next file with comments »