Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2347203002: Build with GN on CT bots. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : better build get_images_from_skps #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -96 lines) Patch
M infra/bots/recipe_modules/flavor/gn_flavor.py View 1 chunk +1 line, -0 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_CPU_BENCH_10k_SKPs.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_100k_SKPs.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_10k_SKPs.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_10k_SKPs_Trybot.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_1m_SKPs.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_1m_SKPs_2slaves_failure.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_DM_1m_SKPs_slave3_failure.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_GPU_BENCH_10k_SKPs.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_GPU_BENCH_1k_SKPs.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_100k_SKPs.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json View 1 chunk +28 lines, -8 lines 0 comments Download
M infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs_Trybot.json View 1 chunk +28 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mtklein_C
Could it possibly be this easy?
4 years, 3 months ago (2016-09-16 15:22:47 UTC) #3
rmistry
On 2016/09/16 15:22:47, mtklein_C wrote: > Could it possibly be this easy? Looks like the ...
4 years, 3 months ago (2016-09-16 15:35:23 UTC) #4
mtklein_C
On 2016/09/16 at 15:35:23, rmistry wrote: > On 2016/09/16 15:22:47, mtklein_C wrote: > > Could ...
4 years, 3 months ago (2016-09-16 15:48:57 UTC) #5
rmistry
On 2016/09/16 15:48:57, mtklein_C wrote: > On 2016/09/16 at 15:35:23, rmistry wrote: > > On ...
4 years, 3 months ago (2016-09-16 17:42:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347203002/40001
4 years, 3 months ago (2016-09-16 18:08:34 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 18:39:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/bfef32ff0ac743b10995985b891f5fd09fe918db

Powered by Google App Engine
This is Rietveld 408576698