infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json - Issue 2347203002: Build with GN on CT bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json

Issue 2347203002: Build with GN on CT bots. (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_100k_SKPs.json ('k') | infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs_Trybot.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json

diff --git a/infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json b/infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json

index b6d00221403ebdc0bdc1e4c2e8dd665b0ec09966..551baa05da6b02058f89345e7fee800ab90b65a1 100644

--- a/infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json

+++ b/infra/bots/recipes/swarm_ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json

@@ -143,18 +143,38 @@

{

"cmd": [

- "make",

- "tools"

+ "[CUSTOM_/_B_WORK]/skia/bin/fetch-gn"

"cwd": "[CUSTOM_/_B_WORK]/skia",

"env": {

- "BUILDTYPE": "Debug",

- "CHROME_HEADLESS": "1",

- "CHROME_PATH": "[SLAVE_BUILD]/src",

- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]",

- "SKIA_OUT": "[SLAVE_BUILD]/out"

+ "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]"

+ },

+ "name": "fetch-gn"

+ },

+ {

+ "cmd": [

+ "gn",

+ "gen",

+ "[SLAVE_BUILD]/out/Debug",

+ "--args=cc=\"gcc\" cxx=\"g++\""

+ ],

+ "cwd": "[CUSTOM_/_B_WORK]/skia",

+ "env": {

+ "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]"

+ },

+ "name": "gn gen"

+ },

+ {

+ "cmd": [

+ "ninja",

+ "-C",

+ "[SLAVE_BUILD]/out/Debug"

+ ],

+ "cwd": "[CUSTOM_/_B_WORK]/skia",

+ "env": {

+ "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]"

- "name": "build tools"

+ "name": "ninja"

{

"cmd": [