Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 2347193002: [M54] Roll-up of fixes for VP8/VP9 stability on Android. (Closed)

Created:
4 years, 3 months ago by liberato (no reviews please)
Modified:
4 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[M54] Roll-up of fixes for VP8/VP9 stability on Android. This is a roll-up of: https://codereview.chromium.org/2332253004 https://codereview.chromium.org/2334223009 https://codereview.chromium.org/2348653002 ==== Don't require free PicturBuffers when draining AVDA for destroy. When draining AVDA for destroy or reset, DequeueOutput will discard any decoded frames from the codec. Previously, it would still refuse to check for available output unless a free picture buffer was available to hold it. This could prevent a flush for destroy or reset from completing. In the case of destruction, this would also prevent the codec from being released. This affected only VP8 codecs, which require a drain on some platforms. https://codereview.chromium.org/2332253004 ==== Don't use AVDA for <360p VPx content. Power measurements on a nexus 5 show that there's very little difference below 360p between hardware and libvpx decoding. This CL switches to libvpx decoding for <360p, even if it could be hardware accelerated by AVDA. This saves a hardware codec instance, and avoids potential stability issues with lots of MediaCodecs in use at once. https://codereview.chromium.org/2334223009 ==== Always allow MediaCodec for encrypted VPx content. https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx content < 360p. Unfortunately, it did not have an exception for encrypted content. This CL adds an addition "encrypted only" profile that covers all supported sizes. https://codereview.chromium.org/2348653002 BUG=647259, 642948 TEST=manually checked 240p and 360p. NOPRESUBMIT=true NOTRY=true TBR=dalecurtis@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -20 lines) Patch
M media/gpu/android_video_decode_accelerator.cc View 3 chunks +43 lines, -20 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347193002/1
4 years, 3 months ago (2016-09-16 14:55:03 UTC) #2
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 14:59:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698