Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2348653002:
Always allow MediaCodec for encrypted VPx content. (Closed)
|
Created:
4 years, 3 months ago by liberato (no reviews please) Modified:
4 years, 3 months ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAlways allow MediaCodec for encrypted VPx content.
https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx
content < 360p. Unfortunately, it did not have an exception for
encrypted content.
This CL adds an addition "encrypted only" profile that covers all
supported sizes.
BUG=647259, 642948
Committed: https://crrev.com/d532efaca37fc8a3c7de35e09bf2e0ecc922f199
Cr-Commit-Position: refs/heads/master@{#419108}
Patch Set 1 #Patch Set 2 : cleanup #
Total comments: 5
Patch Set 3 : cache IsKnownUnaccelerated #Messages
Total messages: 16 (7 generated)
Description was changed from ========== Always allow MediaCodec for encrypted VPx content. https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx content < 360p. Unfortunately, it did not have an exception for encrypted content. This CL adds an addition "encrypted only" profile that covers all supported sizes. BUG=647259, 642948 ========== to ========== Always allow MediaCodec for encrypted VPx content. https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx content < 360p. Unfortunately, it did not have an exception for encrypted content. This CL adds an addition "encrypted only" profile that covers all supported sizes. BUG=647259, 642948 ==========
liberato@chromium.org changed reviewers: + dalecurtis@chromium.org
good catch, thanks. thanks -fl
lgtm https://codereview.chromium.org/2348653002/diff/20001/media/gpu/android_video... File media/gpu/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/2348653002/diff/20001/media/gpu/android_video... media/gpu/android_video_decode_accelerator.cc:1585: profile.encrypted_only = Query outside loop? https://codereview.chromium.org/2348653002/diff/20001/media/gpu/android_video... media/gpu/android_video_decode_accelerator.cc:1609: profile.encrypted_only = VideoCodecBridge::IsKnownUnaccelerated( Ditto.
https://codereview.chromium.org/2348653002/diff/20001/media/gpu/android_video... File media/gpu/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/2348653002/diff/20001/media/gpu/android_video... media/gpu/android_video_decode_accelerator.cc:1585: profile.encrypted_only = On 2016/09/15 22:20:11, DaleCurtis wrote: > Query outside loop? what loop do you mean? https://codereview.chromium.org/2348653002/diff/20001/media/gpu/android_video... media/gpu/android_video_decode_accelerator.cc:1609: profile.encrypted_only = VideoCodecBridge::IsKnownUnaccelerated( On 2016/09/15 22:20:11, DaleCurtis wrote: > Ditto. Done.
lgtm https://codereview.chromium.org/2348653002/diff/20001/media/gpu/android_video... File media/gpu/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/2348653002/diff/20001/media/gpu/android_video... media/gpu/android_video_decode_accelerator.cc:1585: profile.encrypted_only = On 2016/09/15 at 22:30:26, liberato wrote: > On 2016/09/15 22:20:11, DaleCurtis wrote: > > Query outside loop? > > what loop do you mean? https://www.youtube.com/watch?v=mjqysusiZBk
The CQ bit was checked by liberato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Always allow MediaCodec for encrypted VPx content. https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx content < 360p. Unfortunately, it did not have an exception for encrypted content. This CL adds an addition "encrypted only" profile that covers all supported sizes. BUG=647259, 642948 ========== to ========== Always allow MediaCodec for encrypted VPx content. https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx content < 360p. Unfortunately, it did not have an exception for encrypted content. This CL adds an addition "encrypted only" profile that covers all supported sizes. BUG=647259, 642948 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Always allow MediaCodec for encrypted VPx content. https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx content < 360p. Unfortunately, it did not have an exception for encrypted content. This CL adds an addition "encrypted only" profile that covers all supported sizes. BUG=647259, 642948 ========== to ========== Always allow MediaCodec for encrypted VPx content. https://codereview.chromium.org/2334223009 caused AVDA to avoid VPx content < 360p. Unfortunately, it did not have an exception for encrypted content. This CL adds an addition "encrypted only" profile that covers all supported sizes. BUG=647259, 642948 Committed: https://crrev.com/d532efaca37fc8a3c7de35e09bf2e0ecc922f199 Cr-Commit-Position: refs/heads/master@{#419108} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d532efaca37fc8a3c7de35e09bf2e0ecc922f199 Cr-Commit-Position: refs/heads/master@{#419108} |
