Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2347183002: SkPDF: fix unembeddable text drawn with positioning (broken in 6059dc3) (Closed)

Created:
4 years, 3 months ago by hal.canary
Modified:
4 years, 3 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: fix unembeddable text drawn with positioning (broken in 6059dc3) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347183002 Committed: https://skia.googlesource.com/skia/+/2bd295e5a3c24240f6536a72675cc268efb5414e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M src/pdf/SkPDFDevice.cpp View 1 chunk +28 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
hal.canary
PTAL
4 years, 3 months ago (2016-09-16 14:42:31 UTC) #5
bungeman-skia
lgtm
4 years, 3 months ago (2016-09-16 14:54:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347183002/1
4 years, 3 months ago (2016-09-16 14:58:18 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 15:16:00 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2bd295e5a3c24240f6536a72675cc268efb5414e

Powered by Google App Engine
This is Rietveld 408576698