SkPDF: fix unembeddable text drawn with positioning (broken in 6059dc3)

src/pdf/SkPDFDevice.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkPDFDevice.h"
 
 #include "SkAnnotationKeys.h"
@@ skipping 1005 matching lines @@
     if (!typeface) {
         SkDebugf("SkPDF: SkTypeface::MakeDefault() returned nullptr.\n");
         return;
     }
 
     const SkAdvancedTypefaceMetrics* metrics =
         SkPDFFont::GetMetrics(typeface, fDocument->canon());
     if (!metrics) {
         return;
     }
+    int glyphCount = paint.textToGlyphs(sourceText, sourceByteCount, nullptr);
+    if (glyphCount <= 0) {
+        return;
+    }
     // TODO(halcanary): use metrics->fGlyphToUnicode to check Unicode mapping.
     const SkGlyphID maxGlyphID = metrics->fLastGlyphID;
     if (!SkPDFFont::CanEmbedTypeface(typeface, fDocument->canon())) {
         SkPath path; // https://bug.skia.org/3866
-        paint.getTextPath(sourceText, sourceByteCount,
-                          offset.x(), offset.y(), &path);
+        switch (positioning) {
+            case SkTextBlob::kDefault_Positioning:
+                srcPaint.getTextPath(sourceText, sourceByteCount,
+                                     offset.x(), offset.y(), &path);
+                break;
+            case SkTextBlob::kHorizontal_Positioning: {
+                SkAutoTMalloc<SkPoint> positionsBuffer(glyphCount);
+                for (int  i = 0; i < glyphCount; ++i) {
+                    positionsBuffer[i] = offset + SkPoint{pos[i], 0};
+                }
+                srcPaint.getPosTextPath(sourceText, sourceByteCount,
+                                        &positionsBuffer[0], &path);
+                break;
+            }
+            case SkTextBlob::kFull_Positioning: {
+                SkAutoTMalloc<SkPoint> positionsBuffer(glyphCount);
+                for (int  i = 0; i < glyphCount; ++i) {
+                    positionsBuffer[i] = offset + SkPoint{pos[2 * i], pos[2 * i + 1]};
+                }
+                srcPaint.getPosTextPath(sourceText, sourceByteCount,
+                                        &positionsBuffer[0], &path);
+                break;
+            }
+        }
         this->drawPath(d, path, srcPaint, &SkMatrix::I(), true);
         // Draw text transparently to make it copyable/searchable/accessable.
         draw_transparent_text(this, d, sourceText, sourceByteCount,
                               offset.x(), offset.y(), paint);
         return;
     }
-    int glyphCount = paint.textToGlyphs(sourceText, sourceByteCount, nullptr);
-    if (glyphCount <= 0) {
-        return;
-    }
     SkAutoSTMalloc<128, SkGlyphID> glyphStorage;
     const SkGlyphID* glyphs = nullptr;
     if (paint.getTextEncoding() == SkPaint::kGlyphID_TextEncoding) {
         glyphs = (const SkGlyphID*)sourceText;
         // validate input later.
     } else {
         glyphStorage.reset(SkToSizeT(glyphCount));
         (void)paint.textToGlyphs(sourceText, sourceByteCount, glyphStorage.get());
         glyphs = glyphStorage.get();
         paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);
@@ skipping 987 matching lines @@
 }
 
 sk_sp<SkSpecialImage> SkPDFDevice::makeSpecial(const SkImage* image) {
     return SkSpecialImage::MakeFromImage(SkIRect::MakeWH(image->width(), image->height()),
                                          image->makeNonTextureImage());
 }
 
 sk_sp<SkSpecialImage> SkPDFDevice::snapSpecial() {
     return nullptr;
 }