Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 23471005: Use UNLIKELY() macro in generated bindings for minimum argument count checks (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin, do-not-use
Visibility:
Public.

Description

Use UNLIKELY() macro in generated bindings for minimum argument count checks Use UNLIKELY() macro in generated bindings for minimum argument count checks in as a speculative fix for a performance regression caused by making arguments mandatory. It is very unlikely the functions are called without the required number of arguments so we should minimize the impact of this check on performance. R=haraken BUG=285069 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157246

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-04 18:00:44 UTC) #1
haraken
LGTM. Let's land it and revert if we cannot observe any perf improvement.
7 years, 3 months ago (2013-09-04 18:21:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23471005/1
7 years, 3 months ago (2013-09-04 18:23:23 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 21:58:11 UTC) #4
Message was sent while issue was closed.
Change committed as 157246

Powered by Google App Engine
This is Rietveld 408576698