Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp - Issue 23471005: Use UNLIKELY() macro in generated bindings for minimum argument count checks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

Issue 23471005: Use UNLIKELY() macro in generated bindings for minimum argument count checks (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestInterface.cpp ('k') | Source/bindings/tests/results/V8TestMediaQueryListListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp b/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

index d91546a9d4f7126e91e2b6692edc78b0f77ffaa8..085da0382807864a8ac1ce7a4d2f666687784386 100644

--- a/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

@@ -123,7 +123,7 @@ static void bAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::V

static void func1Method(const v8::FunctionCallbackInfo<v8::Value>& args)

{

- if (args.Length() < 1) {

+ if (UNLIKELY(args.Length() < 1)) {

throwNotEnoughArgumentsError(args.GetIsolate());

return;

}

@@ -142,7 +142,7 @@ static void func1MethodCallback(const v8::FunctionCallbackInfo<v8::Value>& args)

static void funcTestInterfaceImplementedAsParamMethod(const v8::FunctionCallbackInfo<v8::Value>& args)

{

- if (args.Length() < 1) {

+ if (UNLIKELY(args.Length() < 1)) {

throwNotEnoughArgumentsError(args.GetIsolate());

return;

}