Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2347053002: Make order of functions in .cc file matches those in .h file for add_to_homescreen_data_fetcher.* (Closed)
Patch Set: Merge branch 'master' into reorder_functions Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index b5d440f4260c78cbb75ab83f848154a25c817702..b1568786b07249bd322f10f6c9660a9ddbecea85 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -96,6 +96,13 @@ AddToHomescreenDataFetcher::AddToHomescreenDataFetcher(
Send(new ChromeViewMsg_GetWebApplicationInfo(routing_id()));
}
+base::Closure AddToHomescreenDataFetcher::FetchSplashScreenImageCallback(
+ const std::string& webapp_id) {
+ return base::Bind(&ShortcutHelper::FetchSplashScreenImage, web_contents(),
+ splash_screen_url_, ideal_splash_image_size_in_dp_,
+ minimum_splash_image_size_in_dp_, webapp_id);
+}
+
void AddToHomescreenDataFetcher::OnDidGetWebApplicationInfo(
const WebApplicationInfo& received_web_app_info) {
is_waiting_for_web_application_info_ = false;
@@ -157,6 +164,27 @@ void AddToHomescreenDataFetcher::OnDidGetWebApplicationInfo(
this));
}
+AddToHomescreenDataFetcher::~AddToHomescreenDataFetcher() {
+ DCHECK(!weak_observer_);
+}
+
+bool AddToHomescreenDataFetcher::OnMessageReceived(
+ const IPC::Message& message) {
+ if (!is_waiting_for_web_application_info_)
+ return false;
+
+ bool handled = true;
+
+ IPC_BEGIN_MESSAGE_MAP(AddToHomescreenDataFetcher, message)
+ IPC_MESSAGE_HANDLER(ChromeViewHostMsg_DidGetWebApplicationInfo,
+ OnDidGetWebApplicationInfo)
+ IPC_MESSAGE_UNHANDLED(handled = false)
+ IPC_END_MESSAGE_MAP()
+
+ return handled;
+}
+
+
void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
const InstallableData& data) {
if (!web_contents() || !weak_observer_)
@@ -199,33 +227,6 @@ void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(
FetchFavicon();
}
-bool AddToHomescreenDataFetcher::OnMessageReceived(
- const IPC::Message& message) {
- if (!is_waiting_for_web_application_info_)
- return false;
-
- bool handled = true;
-
- IPC_BEGIN_MESSAGE_MAP(AddToHomescreenDataFetcher, message)
- IPC_MESSAGE_HANDLER(ChromeViewHostMsg_DidGetWebApplicationInfo,
- OnDidGetWebApplicationInfo)
- IPC_MESSAGE_UNHANDLED(handled = false)
- IPC_END_MESSAGE_MAP()
-
- return handled;
-}
-
-AddToHomescreenDataFetcher::~AddToHomescreenDataFetcher() {
- DCHECK(!weak_observer_);
-}
-
-base::Closure AddToHomescreenDataFetcher::FetchSplashScreenImageCallback(
- const std::string& webapp_id) {
- return base::Bind(&ShortcutHelper::FetchSplashScreenImage, web_contents(),
- splash_screen_url_, ideal_splash_image_size_in_dp_,
- minimum_splash_image_size_in_dp_, webapp_id);
-}
-
void AddToHomescreenDataFetcher::FetchFavicon() {
if (!web_contents() || !weak_observer_)
return;
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698