Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h

Issue 2347053002: Make order of functions in .cc file matches those in .h file for add_to_homescreen_data_fetcher.* (Closed)
Patch Set: Merge branch 'master' into reorder_functions Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
index 12475530fd093eac8d1668e158291cfc2c7ee997..8a9ae31d8f112c63df8952de85c03c1fa42c9108 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h
@@ -89,14 +89,17 @@ class AddToHomescreenDataFetcher
ShortcutInfo& shortcut_info() { return shortcut_info_; }
const SkBitmap& shortcut_icon() const { return shortcut_icon_; }
- // WebContentsObserver
- bool OnMessageReceived(const IPC::Message& message) override;
-
private:
friend class base::RefCounted<AddToHomescreenDataFetcher>;
~AddToHomescreenDataFetcher() override;
+ // WebContentsObserver
+ bool OnMessageReceived(const IPC::Message& message) override;
+
+ // Called when InstallableManager finishes looking for a manifest and icon.
+ void OnDidPerformInstallableCheck(const InstallableData& data);
+
// Grabs the favicon for the current URL.
void FetchFavicon();
void OnFaviconFetched(
@@ -108,9 +111,6 @@ class AddToHomescreenDataFetcher
void CreateLauncherIconFromFaviconInBackground(
const favicon_base::FaviconRawBitmapResult& bitmap_result);
- // Called when InstallableManager finishes looking for a manifest and icon.
- void OnDidPerformInstallableCheck(const InstallableData& data);
-
// Creates the launcher icon from the given |icon|.
void CreateLauncherIconInBackground(const SkBitmap& raw__icon);
« no previous file with comments | « no previous file | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698