Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2347053002: Make order of functions in .cc file matches those in .h file for add_to_homescreen_data_fetcher.* (Closed)

Created:
4 years, 3 months ago by pkotwicz
Modified:
4 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org, Xi Han
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make order of functions in .cc file matches those in .h file for add_to_homescreen_data_fetcher.* BUG=None Committed: https://crrev.com/05bae669f785e0f3a1898a09abe8559bd94936da Cr-Commit-Position: refs/heads/master@{#419221}

Patch Set 1 : Merge branch 'master' into reorder_functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -33 lines) Patch
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 3 chunks +28 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
pkotwicz
Dan can you please take a look?
4 years, 3 months ago (2016-09-16 00:49:08 UTC) #3
gone
lgtm
4 years, 3 months ago (2016-09-16 17:19:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2347053002/20001
4 years, 3 months ago (2016-09-16 17:38:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-16 18:28:09 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 18:29:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05bae669f785e0f3a1898a09abe8559bd94936da
Cr-Commit-Position: refs/heads/master@{#419221}

Powered by Google App Engine
This is Rietveld 408576698