Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1141)

Issue 2346963004: Enable media browsertests on Android (Closed)

Created:
4 years, 3 months ago by watk
Modified:
4 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable media browsertests on Android These have been disabled for a long time. Now that the unified media pipeline is enabled, they should be much more reliable. BUG=582293 Committed: https://crrev.com/e95b5033607824ec2a3441fed4faecd1e7b7b067 Cr-Commit-Position: refs/heads/master@{#419912}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/media/media_browsertest.cc View 4 chunks +7 lines, -1 line 0 comments Download
M content/browser/media/media_color_browsertest.cc View 1 2 4 chunks +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 32 (26 generated)
watk
4 years, 3 months ago (2016-09-16 21:55:16 UTC) #6
DaleCurtis
lgtm
4 years, 3 months ago (2016-09-16 22:17:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346963004/80001
4 years, 3 months ago (2016-09-20 23:14:42 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 3 months ago (2016-09-21 00:14:46 UTC) #28
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e95b5033607824ec2a3441fed4faecd1e7b7b067 Cr-Commit-Position: refs/heads/master@{#419912}
4 years, 3 months ago (2016-09-21 00:18:08 UTC) #30
watk
4 years, 3 months ago (2016-09-21 19:28:36 UTC) #31
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/2356383002/ by watk@chromium.org.

The reason for reverting is: A couple of tests are failing on non-cq bots..

Powered by Google App Engine
This is Rietveld 408576698