Clean up the media color format content_browsertests

Clean up the media color format content_browsertests

* Move them to a new file: media_color_browsertest.cc which is not
  compiled for cast shell because it won't work there.
* EXPECT that these tests succeed (presumably this wasn't done by accident).
* Minor renames/comment clean up.

BUG=582293
Committed: https://crrev.com/a46402f563caaf17237ed9b575dfbc3d47e537de
Cr-Commit-Position: refs/heads/master@{#419829}

[watk, 2016-09-15 20:51:36]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 20:52:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[watk, 2016-09-15 20:53:25]

watk@chromium.org changed reviewers:
+ liberato@chromium.org

[watk, 2016-09-15 20:54:39]

cc dalecurtis@ in case there's a historical reason these didn't check for
success

[liberato (no reviews please), 2016-09-15 21:00:14]

lgtm % dale has no historical reasons why not.

-fl

[commit-bot: I haz the power, 2016-09-15 21:24:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:24:02]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[watk, 2016-09-16 20:14:08]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 20:14:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[watk, 2016-09-16 20:16:46]

Description was changed from

==========
The media color format content_browsertests now check for success

These tests previously didn't EXPECT success (presumably by accident).
Now they do.

BUG=582293
==========

to

==========
Clean up the media color format content_browsertests

* Move them to a new file: media_color_browsertest.cc which is not
  compiled for cast shell because it won't work there.
* EXPECT that these tests succeed (presumably this wasn't done by accident). 
* Minor renames/comment clean up.

BUG=582293
==========

[watk, 2016-09-16 20:18:33]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 20:19:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[DaleCurtis, 2016-09-16 22:19:12]

dalecurtis@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[DaleCurtis, 2016-09-16 22:19:12]

Not that I know of.

[DaleCurtis, 2016-09-16 22:19:14]

lgtm

[watk, 2016-09-16 22:35:10]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 22:35:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:51:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 22:51:08]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[watk, 2016-09-16 22:55:31]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 22:56:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 23:41:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[watk, 2016-09-17 00:10:25]

Patchset #6 (id:100001) has been deleted

[watk, 2016-09-17 00:11:03]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 00:11:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[watk, 2016-09-17 01:05:19]

The CQ bit was unchecked by watk@chromium.org

[watk, 2016-09-17 01:05:20]

The CQ bit was checked by watk@chromium.org

[watk, 2016-09-17 01:05:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
liberato@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2345073002/#ps120001
(title: "Disable on chromos")

[watk, 2016-09-17 01:05:25]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2016-09-17 01:05:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 01:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 01:13:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[watk, 2016-09-17 01:16:31]

watk@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[watk, 2016-09-17 01:16:32]

phajdan.jr@chromium.org: Please review changes in content/test/BUILD.gn

[Paweł Hajdan Jr., 2016-09-19 23:20:56]

LGTM

[watk, 2016-09-20 17:00:48]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:01:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 18:52:17]

Description was changed from

==========
Clean up the media color format content_browsertests

* Move them to a new file: media_color_browsertest.cc which is not
  compiled for cast shell because it won't work there.
* EXPECT that these tests succeed (presumably this wasn't done by accident). 
* Minor renames/comment clean up.

BUG=582293
==========

to

==========
Clean up the media color format content_browsertests

* Move them to a new file: media_color_browsertest.cc which is not
  compiled for cast shell because it won't work there.
* EXPECT that these tests succeed (presumably this wasn't done by accident). 
* Minor renames/comment clean up.

BUG=582293
==========

[commit-bot: I haz the power, 2016-09-20 18:52:18]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-09-20 18:53:46]

Description was changed from

==========
Clean up the media color format content_browsertests

* Move them to a new file: media_color_browsertest.cc which is not
  compiled for cast shell because it won't work there.
* EXPECT that these tests succeed (presumably this wasn't done by accident). 
* Minor renames/comment clean up.

BUG=582293
==========

to

==========
Clean up the media color format content_browsertests

* Move them to a new file: media_color_browsertest.cc which is not
  compiled for cast shell because it won't work there.
* EXPECT that these tests succeed (presumably this wasn't done by accident).
* Minor renames/comment clean up.

BUG=582293

Committed: https://crrev.com/a46402f563caaf17237ed9b575dfbc3d47e537de
Cr-Commit-Position: refs/heads/master@{#419829}
==========

[commit-bot: I haz the power, 2016-09-20 18:53:47]

Patchset 6 (id:??) landed as
https://crrev.com/a46402f563caaf17237ed9b575dfbc3d47e537de
Cr-Commit-Position: refs/heads/master@{#419829}