Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: scripts/slave/unittests/results_dashboard_test.py

Issue 2346963003: Updating perf recipe for disabled chartjson data. (Closed)
Patch Set: responding to review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/runtest.py ('k') | scripts/slave/unittests/runtest_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/unittests/results_dashboard_test.py
diff --git a/scripts/slave/unittests/results_dashboard_test.py b/scripts/slave/unittests/results_dashboard_test.py
index 4cd86a48caa6584bd13e7ea6ec3b4f9dfd722be7..c467c68896cf4232fc1fc31042b643b7e543104e 100755
--- a/scripts/slave/unittests/results_dashboard_test.py
+++ b/scripts/slave/unittests/results_dashboard_test.py
@@ -42,6 +42,12 @@ class ResultsDashboardFormatTest(unittest.TestCase):
self.mox.UnsetStubs()
def test_MakeDashboardJsonV1(self):
+ self.internal_Test_MakeDashboardJsonV1()
+
+ def test_MakeDashboardJsonV1WithDisabledBenchmark(self):
+ self.internal_Test_MakeDashboardJsonV1(False)
+
+ def internal_Test_MakeDashboardJsonV1(self, enabled=True):
self.mox.StubOutWithMock(slave_utils, 'GetActiveMaster')
slave_utils.GetActiveMaster().AndReturn('ChromiumPerf')
self.mox.StubOutWithMock(results_dashboard, '_GetTimestamp')
@@ -51,7 +57,7 @@ class ResultsDashboardFormatTest(unittest.TestCase):
self.mox.ReplayAll()
v1json = results_dashboard.MakeDashboardJsonV1(
- {'some_json': 'from_telemetry'},
+ {'some_json': 'from_telemetry', 'enabled': enabled},
{
'rev': 'f46bf3c',
'git_revision': 'f46bf3c',
@@ -68,7 +74,7 @@ class ResultsDashboardFormatTest(unittest.TestCase):
{
'master': 'ChromiumPerf',
'bot': 'my-bot',
- 'chart_data': {'some_json': 'from_telemetry'},
+ 'chart_data': {'some_json': 'from_telemetry', 'enabled': enabled},
'is_ref': True,
'test_suite_name': 'foo_test',
'point_id': 307226,
« no previous file with comments | « scripts/slave/runtest.py ('k') | scripts/slave/unittests/runtest_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698