Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: scripts/slave/runtest.py

Issue 2346963003: Updating perf recipe for disabled chartjson data. (Closed)
Patch Set: responding to review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/unittests/results_dashboard_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/runtest.py
diff --git a/scripts/slave/runtest.py b/scripts/slave/runtest.py
index a4f633acd21c4e6cf804ada708651788280bc1c3..1e7cd00e1ac3573071781eb17c5ada63c06f7843 100755
--- a/scripts/slave/runtest.py
+++ b/scripts/slave/runtest.py
@@ -677,9 +677,9 @@ def _WriteChartJsonToOutput(chartjson_file, log_processor, args):
assert log_processor.IsChartJson()
chartjson_data = _GenerateDashboardJson(log_processor, args)
-
- with open(chartjson_file, 'w') as f:
- json.dump(chartjson_data, f)
+ if chartjson_data:
+ with open(chartjson_file, 'w') as f:
+ json.dump(chartjson_data, f)
def _SendResultsToDashboard(log_processor, args):
@@ -705,6 +705,8 @@ def _SendResultsToDashboard(log_processor, args):
print 'Error: No json output from telemetry.'
print '@@@STEP_FAILURE@@@'
log_processor.Cleanup()
+ if results and not results['chart_data'].get('enabled', True):
+ return True # A successful run, but the benchmark was disabled.
else:
charts = _GetDataFromLogProcessor(log_processor)
results = results_dashboard.MakeListOfPoints(
« no previous file with comments | « no previous file | scripts/slave/unittests/results_dashboard_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698