Issue 2346913003: Make rebase_path("//foo", "//foo") resolve to "." (not "../foo")

Issue 2346913003: Make rebase_path("//foo", "//foo") resolve to "." (not "../foo") (Closed)

Created:
4 years, 3 months ago by agrieve

Modified:
4 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews, Dirk Pranke, tfarina

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Make rebase_path("//foo", "//foo") resolve to "." (not "../foo") BUG=647679 Committed: https://crrev.com/3d56c98e60572a809a47918ef98e7b3d9138c5ad Cr-Commit-Position: refs/heads/master@{#419229}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -7 lines)			Patch
	M	tools/gn/function_rebase_path.cc	View		1 chunk	+14 lines, -4 lines	0 comments	Download
	M	tools/gn/function_rebase_path_unittest.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 8 (3 generated)

agrieve

It was causing "../foo" to show up in a depfile, which ninja didn't like.

4 years, 3 months ago (2016-09-16 13:49:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346913003/1

4 years, 3 months ago (2016-09-16 18:00:39 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-09-16 18:43:58 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3d56c98e60572a809a47918ef98e7b3d9138c5ad
Cr-Commit-Position: refs/heads/master@{#419229}