Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2346903002: Fixes for WebContents associated interfaces support (Closed)

Created:
4 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes for WebContents associated interfaces support These weren't caught in the original CL (https://codereview.chromium.org/2310563002) since that CL intentionally didn't exercise everything. I neglected to test the follow-up CL completely before landing the first one, so I missed these bugs: 1. WebContentsBindingSet::Binding needs to be exported 2. The RouteProvider proxy in RPHI needs to reset on Init 3. RenderFrameImpl never implemented IPC::Listener::OnAssociatedInterfaceRequest. *crawls into shame cube* Landing these fixes separately from the follow-up CL (https://codereview.chromium.org/2310583002) to retain its purpose as a minimal example of WebContents IPC conversion. BUG=612500 Committed: https://crrev.com/ce2138c89ef807204d1fab4a2716d86bbe918092 Cr-Commit-Position: refs/heads/master@{#419046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_binding_set.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 25 (20 generated)
Ken Rockot(use gerrit already)
Actually tested now...
4 years, 3 months ago (2016-09-15 22:57:29 UTC) #17
jam
lgtm
4 years, 3 months ago (2016-09-15 23:51:50 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346903002/60001
4 years, 3 months ago (2016-09-16 00:04:01 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 3 months ago (2016-09-16 00:10:17 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 00:14:09 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce2138c89ef807204d1fab4a2716d86bbe918092
Cr-Commit-Position: refs/heads/master@{#419046}

Powered by Google App Engine
This is Rietveld 408576698