Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2346893002: Share a common alpha value used for displaying disabled state in Harmony (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
Elly Fong-Jones, sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Share a common alpha value used for displaying disabled state in Harmony controls. In the future it might be desirable to remove some disabled color IDs (like LabelDisabledColor) in favor of just applying this alpha at callsites. BUG=none Committed: https://crrev.com/def1af9b4c59dc452c2739b790b656f9a489a29d Cr-Commit-Position: refs/heads/master@{#419488}

Patch Set 1 #

Patch Set 2 : compiling is underrated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M ui/gfx/color_palette.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/native_theme/common_theme.cc View 2 chunks +7 lines, -1 line 0 comments Download
M ui/native_theme/native_theme_dark_aura.cc View 3 chunks +1 line, -3 lines 0 comments Download
M ui/views/controls/button/md_text_button.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/controls/button/toggle_button.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/controls/focusable_border.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Evan Stade
4 years, 3 months ago (2016-09-16 17:55:52 UTC) #2
sky
LGTM
4 years, 3 months ago (2016-09-16 21:13:56 UTC) #3
Elly Fong-Jones
lgtm
4 years, 3 months ago (2016-09-19 11:08:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346893002/20001
4 years, 3 months ago (2016-09-19 16:22:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-19 17:11:22 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 17:13:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/def1af9b4c59dc452c2739b790b656f9a489a29d
Cr-Commit-Position: refs/heads/master@{#419488}

Powered by Google App Engine
This is Rietveld 408576698