Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: components/drive/resource_metadata_storage.cc

Issue 2346873004: Added 'starred' to EntryProperty in FileManagerPrivateAPI. (Closed)
Patch Set: Change tag name 'has_starred' into 'starred_property_initialized.' Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/drive/resource_metadata_storage.cc
diff --git a/components/drive/resource_metadata_storage.cc b/components/drive/resource_metadata_storage.cc
index 8a0eb35bef7530689e1f077f321e57c3c44ffc43..e263badce9c4d084d5f80384a350f6b6af22716e 100644
--- a/components/drive/resource_metadata_storage.cc
+++ b/components/drive/resource_metadata_storage.cc
@@ -630,6 +630,22 @@ bool ResourceMetadataStorage::Initialize() {
}
}
+ // Update local resouces if 'starred' property has not been initialized.
+ if (resource_map_) {
+ bool update_needed = false;
+ ResourceMetadataHeader header;
+ if (GetHeader(&header) == FILE_ERROR_OK)
hashimoto 2016/09/29 08:43:43 GetHeader() shouldn't fail here. If it fails, it's
harukam 2016/09/29 09:39:45 Acknowledged.
+ update_needed = !header.starred_property_initialized();
+
+ if (update_needed) {
+ FileError error = SetLargestChangestamp(0);
hashimoto 2016/09/29 08:43:43 Instead of SetLargestChangestamp() & PutHeader(),
harukam 2016/09/29 09:39:46 Thanks.
+ if (error == FILE_ERROR_OK && GetHeader(&header) == FILE_ERROR_OK) {
+ header.set_starred_property_initialized(true);
+ PutHeader(header);
hashimoto 2016/09/29 08:43:43 Please check for an error here.
harukam 2016/09/29 09:39:46 Done.
+ }
+ }
+ }
+
UMA_HISTOGRAM_ENUMERATION("Drive.MetadataDBInitResult",
init_result,
DB_INIT_MAX_VALUE);

Powered by Google App Engine
This is Rietveld 408576698