Added 'starred' to EntryProperty in FileManagerPrivateAPI.

components/drive/resource_metadata_storage.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/drive/resource_metadata_storage.h"
 
 #include <stddef.h>
 
 #include <map>
 #include <set>
@@ skipping 612 matching lines @@
       } else {
         init_result = DB_INIT_FAILED;
         resource_map_.reset();
       }
     } else {
       LOG(ERROR) << "Failed to create resource map DB: " << status.ToString();
       init_result = LevelDBStatusToDBInitStatus(status);
     }
   }
 
+  // Update local resouces if 'starred' property has not been initialized.
+  if (resource_map_) {
+    bool update_needed = false;
+    ResourceMetadataHeader header;
+    if (GetHeader(&header) == FILE_ERROR_OK)

[hashimoto, 2016/09/29 08:43:43]

GetHeader() shouldn't fail here.
If it fails, it's better to return false to abort.

[harukam, 2016/09/29 09:39:45]

Acknowledged.

+      update_needed = !header.starred_property_initialized();
+
+    if (update_needed) {
+      FileError error = SetLargestChangestamp(0);

[hashimoto, 2016/09/29 08:43:43]

Instead of SetLargestChangestamp() & PutHeader(), you can do the same thing with
a single PutHeader() (SetLargestChangestamp is just a wrapper of PutHeader).

header.largest_changestamp(0);
header.set_starred_proeprty_initialized(true);
error = PutHeader(header);

[harukam, 2016/09/29 09:39:46]

Thanks.

+      if (error == FILE_ERROR_OK && GetHeader(&header) == FILE_ERROR_OK) {
+        header.set_starred_property_initialized(true);
+        PutHeader(header);

[hashimoto, 2016/09/29 08:43:43]

Please check for an error here.

[harukam, 2016/09/29 09:39:46]

Done.

+      }
+    }
+  }
+
   UMA_HISTOGRAM_ENUMERATION("Drive.MetadataDBInitResult",
                             init_result,
                             DB_INIT_MAX_VALUE);
   return !!resource_map_;
 }
 
 void ResourceMetadataStorage::RecoverCacheInfoFromTrashedResourceMap(
     RecoveredCacheInfoMap* out_info) {
   const base::FilePath trashed_resource_map_path =
       directory_path_.Append(kTrashedResourceMapDBName);
@@ skipping 418 matching lines @@
     RecordCheckValidityFailure(
         CHECK_VALIDITY_FAILURE_CHILD_ENTRY_COUNT_MISMATCH);
     return false;
   }
 
   return true;
 }
 
 }  // namespace internal
 }  // namespace drive